diff options
| author | zeertzjq <zeertzjq@outlook.com> | 2022-07-29 07:31:54 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-07-29 07:31:54 +0800 |
| commit | 88ed33230ac91423f6e09c3f7c07cc02b2b115ac (patch) | |
| tree | f91f1f339e3ddd3468af71b61361a20f0bacc635 | |
| parent | 352a177dae5b602f5685faa3ce4ad841d3ddbc15 (diff) | |
| download | rneovim-88ed33230ac91423f6e09c3f7c07cc02b2b115ac.tar.gz rneovim-88ed33230ac91423f6e09c3f7c07cc02b2b115ac.tar.bz2 rneovim-88ed33230ac91423f6e09c3f7c07cc02b2b115ac.zip | |
vim-patch:9.0.0101: invalid memory access in diff mode with "dp" and undo (#19568)
Problem: Invalid memory access in diff mode with "dp" and undo.
Solution: Make sure the line number does not go below one.
https://github.com/vim/vim/commit/4e677b9c40ccbc5f090971b31dc2fe07bf05541d
| -rw-r--r-- | src/nvim/diff.c | 14 | ||||
| -rw-r--r-- | src/nvim/testdir/test_diffmode.vim | 14 |
2 files changed, 23 insertions, 5 deletions
diff --git a/src/nvim/diff.c b/src/nvim/diff.c index 59a1ce9932..f43eaaa299 100644 --- a/src/nvim/diff.c +++ b/src/nvim/diff.c @@ -419,10 +419,13 @@ static void diff_mark_adjust_tp(tabpage_T *tp, int idx, linenr_T line1, linenr_T } } - int i; - for (i = 0; i < DB_COUNT; i++) { + for (int i = 0; i < DB_COUNT; i++) { if ((tp->tp_diffbuf[i] != NULL) && (i != idx)) { - dp->df_lnum[i] -= off; + if (dp->df_lnum[i] > off) { + dp->df_lnum[i] -= off; + } else { + dp->df_lnum[i] = 1; + } dp->df_count[i] += n; } } @@ -2707,8 +2710,9 @@ void ex_diffgetput(exarg_T *eap) for (i = 0; i < count; i++) { // remember deleting the last line of the buffer buf_empty = curbuf->b_ml.ml_line_count == 1; - ml_delete(lnum, false); - added--; + if (ml_delete(lnum, false) == OK) { + added--; + } } for (i = 0; i < dp->df_count[idx_from] - start_skip - end_skip; i++) { diff --git a/src/nvim/testdir/test_diffmode.vim b/src/nvim/testdir/test_diffmode.vim index bc931b1e1b..1dbbe578c5 100644 --- a/src/nvim/testdir/test_diffmode.vim +++ b/src/nvim/testdir/test_diffmode.vim @@ -1471,5 +1471,19 @@ func Test_diff_manipulations() %bwipe! endfunc +" This was causing the line number in the diff block to go below one. +" FIXME: somehow this causes a valgrind error when run directly but not when +" run as a test. +func Test_diff_put_and_undo() + set diff + next 0 + split 00 + sil! norm o0gguudpo0ggJuudp + + bwipe! + bwipe! + set nodiff +endfunc + " vim: shiftwidth=2 sts=2 expandtab |