diff options
| author | zeertzjq <zeertzjq@outlook.com> | 2024-08-08 14:51:29 +0800 |
|---|---|---|
| committer | zeertzjq <zeertzjq@outlook.com> | 2024-08-08 14:54:14 +0800 |
| commit | 92186be428e84798ac6fa6c69ae575187a0d3da8 (patch) | |
| tree | 3727bd684e89d18076077de1e085a12cc3bb3129 | |
| parent | f35d5afbf1bae81896d4b959c7d99cf50e0c306f (diff) | |
| download | rneovim-92186be428e84798ac6fa6c69ae575187a0d3da8.tar.gz rneovim-92186be428e84798ac6fa6c69ae575187a0d3da8.tar.bz2 rneovim-92186be428e84798ac6fa6c69ae575187a0d3da8.zip | |
vim-patch:8.2.3476: renaming a buffer on startup may cause using freed memory
Problem: Renaming a buffer on startup may cause using freed memory.
Solution: Check if the buffer is used in a window. (closes vim/vim#8955)
https://github.com/vim/vim/commit/d3710cf01ef6ab1b2f233866ff01dab76686f642
Cherry-pick Test_echo_true_in_cmd() from Vim.
Co-authored-by: Bram Moolenaar <Bram@vim.org>
| -rw-r--r-- | src/nvim/buffer.c | 12 | ||||
| -rw-r--r-- | test/old/testdir/test_startup.vim | 30 |
2 files changed, 41 insertions, 1 deletions
diff --git a/src/nvim/buffer.c b/src/nvim/buffer.c index 0c301bd5e2..ab648708fc 100644 --- a/src/nvim/buffer.c +++ b/src/nvim/buffer.c @@ -2959,7 +2959,17 @@ int setfname(buf_T *buf, char *ffname_arg, char *sfname_arg, bool message) obuf = buflist_findname_file_id(ffname, &file_id, file_id_valid); } if (obuf != NULL && obuf != buf) { - if (obuf->b_ml.ml_mfp != NULL) { // it's loaded, fail + bool in_use = false; + + // during startup a window may use a buffer that is not loaded yet + FOR_ALL_TAB_WINDOWS(tab, win) { + if (win->w_buffer == obuf) { + in_use = true; + } + } + + // it's loaded or used in a window, fail + if (obuf->b_ml.ml_mfp != NULL || in_use) { if (message) { emsg(_("E95: Buffer with this name already exists")); } diff --git a/test/old/testdir/test_startup.vim b/test/old/testdir/test_startup.vim index c80d98925a..c46b4002c2 100644 --- a/test/old/testdir/test_startup.vim +++ b/test/old/testdir/test_startup.vim @@ -1276,4 +1276,34 @@ func Test_write_in_vimrc() call delete('Xvimrc') endfunc +func Test_echo_true_in_cmd() + CheckNotGui + + let lines =<< trim END + echo v:true + call writefile(['done'], 'Xresult') + quit + END + call writefile(lines, 'Xscript') + if RunVim([], [], '--cmd "source Xscript"') + call assert_equal(['done'], readfile('Xresult')) + endif + call delete('Xscript') + call delete('Xresult') +endfunc + +func Test_rename_buffer_on_startup() + let lines =<< trim END + call writefile(['done'], 'Xresult') + qa! + END + call writefile(lines, 'Xscript') + if RunVim([], [], "--clean -e -s --cmd 'file x|new|file x' --cmd 'so Xscript'") + call assert_equal(['done'], readfile('Xresult')) + endif + call delete('Xscript') + call delete('Xresult') +endfunc + + " vim: shiftwidth=2 sts=2 expandtab |