unittests: Check core dumps in after_each, like in functests

25 files changed, 43 insertions, 24 deletions

diff --git a/test/helpers.lua b/test/helpers.lua
index 25ab80bb50..ecf90869c4 100644
--- a/test/helpers.lua
+++ b/test/helpers.lua
@@ -212,6 +212,14 @@ local function check_cores(app)
   end
 end
 
+local function which(exe)
+  local pipe = io.popen('which ' .. exe, 'r')
+  local ret = pipe:read('*a')
+  pipe:close()
+  assert(ret:sub(-1) == '\n')
+  return ret:sub(1, -2)
+end
+
 return {
   eq = eq,
   neq = neq,
@@ -224,4 +232,5 @@ return {
   glob = glob,
   check_cores = check_cores,
   hasenv = hasenv,
+  which = which,
 }
diff --git a/test/unit/api/helpers.lua b/test/unit/api/helpers.lua
index 166456d2a1..750e2f3c77 100644
--- a/test/unit/api/helpers.lua
+++ b/test/unit/api/helpers.lua
@@ -1,4 +1,4 @@
-local helpers = require('test.unit.helpers')
+local helpers = require('test.unit.helpers')(nil)
 local eval_helpers = require('test.unit.eval.helpers')
 
 local cimport = helpers.cimport
diff --git a/test/unit/api/private_helpers_spec.lua b/test/unit/api/private_helpers_spec.lua
index eb88f486f6..a534d83165 100644
--- a/test/unit/api/private_helpers_spec.lua
+++ b/test/unit/api/private_helpers_spec.lua
@@ -1,4 +1,4 @@
-local helpers = require('test.unit.helpers')
+local helpers = require('test.unit.helpers')(after_each)
 local itp = helpers.gen_itp(it)
 local eval_helpers = require('test.unit.eval.helpers')
 local api_helpers = require('test.unit.api.helpers')
diff --git a/test/unit/buffer_spec.lua b/test/unit/buffer_spec.lua
index a4d1be0dd4..f7124b2782 100644
--- a/test/unit/buffer_spec.lua
+++ b/test/unit/buffer_spec.lua
@@ -1,5 +1,5 @@
 
-local helpers = require("test.unit.helpers")
+local helpers = require("test.unit.helpers")(after_each)
 local itp = helpers.gen_itp(it)
 
 local to_cstr = helpers.to_cstr
diff --git a/test/unit/eval/decode_spec.lua b/test/unit/eval/decode_spec.lua
index 03fe556001..a32ecf8ed0 100644
--- a/test/unit/eval/decode_spec.lua
+++ b/test/unit/eval/decode_spec.lua
@@ -1,4 +1,4 @@
-local helpers = require('test.unit.helpers')
+local helpers = require('test.unit.helpers')(after_each)
 local itp = helpers.gen_itp(it)
 
 local cimport = helpers.cimport
diff --git a/test/unit/eval/encode_spec.lua b/test/unit/eval/encode_spec.lua
index 1f065e59a1..058c55093e 100644
--- a/test/unit/eval/encode_spec.lua
+++ b/test/unit/eval/encode_spec.lua
@@ -1,4 +1,4 @@
-local helpers = require('test.unit.helpers')
+local helpers = require('test.unit.helpers')(after_each)
 local itp = helpers.gen_itp(it)
 local eval_helpers = require('test.unit.eval.helpers')
 
diff --git a/test/unit/eval/helpers.lua b/test/unit/eval/helpers.lua
index c3c27e4fed..ee9b423eb6 100644
--- a/test/unit/eval/helpers.lua
+++ b/test/unit/eval/helpers.lua
@@ -1,4 +1,4 @@
-local helpers = require('test.unit.helpers')
+local helpers = require('test.unit.helpers')(nil)
 
 local cimport = helpers.cimport
 local to_cstr = helpers.to_cstr
diff --git a/test/unit/eval/tricks_spec.lua b/test/unit/eval/tricks_spec.lua
index ff63dc5cde..ec79a9cad5 100644
--- a/test/unit/eval/tricks_spec.lua
+++ b/test/unit/eval/tricks_spec.lua
@@ -1,4 +1,4 @@
-local helpers = require('test.unit.helpers')
+local helpers = require('test.unit.helpers')(after_each)
 local itp = helpers.gen_itp(it)
 
 local cimport = helpers.cimport
diff --git a/test/unit/eval/tv_clear_spec.lua b/test/unit/eval/tv_clear_spec.lua
index 7601192f47..47d4661ad8 100644
--- a/test/unit/eval/tv_clear_spec.lua
+++ b/test/unit/eval/tv_clear_spec.lua
@@ -1,4 +1,4 @@
-local helpers = require('test.unit.helpers')
+local helpers = require('test.unit.helpers')(after_each)
 local itp = helpers.gen_itp(it)
 local eval_helpers = require('test.unit.eval.helpers')
 
diff --git a/test/unit/fileio_spec.lua b/test/unit/fileio_spec.lua
index 13ff5d1f11..066d013b19 100644
--- a/test/unit/fileio_spec.lua
+++ b/test/unit/fileio_spec.lua
@@ -1,4 +1,4 @@
-local helpers = require("test.unit.helpers")
+local helpers = require("test.unit.helpers")(after_each)
 local itp = helpers.gen_itp(it)
 --{:cimport, :internalize, :eq, :neq, :ffi, :lib, :cstr, :to_cstr} = require 'test.unit.helpers'
 
diff --git a/test/unit/garray_spec.lua b/test/unit/garray_spec.lua
index e55c514353..ffa0f15717 100644
--- a/test/unit/garray_spec.lua
+++ b/test/unit/garray_spec.lua
@@ -1,4 +1,4 @@
-local helpers = require("test.unit.helpers")
+local helpers = require("test.unit.helpers")(after_each)
 local itp = helpers.gen_itp(it)
 
 local cimport = helpers.cimport
diff --git a/test/unit/helpers.lua b/test/unit/helpers.lua
index 9d200a8721..b6fcc959ef 100644
--- a/test/unit/helpers.lua
+++ b/test/unit/helpers.lua
@@ -10,6 +10,8 @@ local say = require('say')
 local posix = nil
 local syscall = nil
 
+local check_cores = global_helpers.check_cores
+local which = global_helpers.which
 local neq = global_helpers.neq
 local eq = global_helpers.eq
 local ok = global_helpers.ok
@@ -431,7 +433,7 @@ local function gen_itp(it)
   return itp
 end
 
-return {
+local module = {
   cimport = cimport,
   cppimport = cppimport,
   internalize = internalize,
@@ -448,3 +450,11 @@ return {
   alloc_log_new = alloc_log_new,
   gen_itp = gen_itp,
 }
+return function(after_each)
+  if after_each then
+    after_each(function()
+      check_cores(which('luajit'))
+    end)
+  end
+  return module
+end
diff --git a/test/unit/mbyte_spec.lua b/test/unit/mbyte_spec.lua
index a772a5d5e5..6feef4e601 100644
--- a/test/unit/mbyte_spec.lua
+++ b/test/unit/mbyte_spec.lua
@@ -1,4 +1,4 @@
-local helpers = require("test.unit.helpers")
+local helpers = require("test.unit.helpers")(after_each)
 local itp = helpers.gen_itp(it)
 
 local ffi     = helpers.ffi
diff --git a/test/unit/memory_spec.lua b/test/unit/memory_spec.lua
index 744ff3cf19..bd72c8bf47 100644
--- a/test/unit/memory_spec.lua
+++ b/test/unit/memory_spec.lua
@@ -1,4 +1,4 @@
-local helpers = require("test.unit.helpers")
+local helpers = require("test.unit.helpers")(after_each)
 local itp = helpers.gen_itp(it)
 
 local cimport = helpers.cimport
diff --git a/test/unit/multiqueue_spec.lua b/test/unit/multiqueue_spec.lua
index 632a091d60..b72040a396 100644
--- a/test/unit/multiqueue_spec.lua
+++ b/test/unit/multiqueue_spec.lua
@@ -1,4 +1,4 @@
-local helpers = require("test.unit.helpers")
+local helpers = require("test.unit.helpers")(after_each)
 local itp = helpers.gen_itp(it)
 
 local ffi     = helpers.ffi
diff --git a/test/unit/option_spec.lua b/test/unit/option_spec.lua
index b8bfeaf93e..b8b8a435bc 100644
--- a/test/unit/option_spec.lua
+++ b/test/unit/option_spec.lua
@@ -1,4 +1,4 @@
-local helpers = require("test.unit.helpers")
+local helpers = require("test.unit.helpers")(after_each)
 local itp = helpers.gen_itp(it)
 
 local to_cstr = helpers.to_cstr
diff --git a/test/unit/os/env_spec.lua b/test/unit/os/env_spec.lua
index ba6ae65a04..1ffed784ff 100644
--- a/test/unit/os/env_spec.lua
+++ b/test/unit/os/env_spec.lua
@@ -1,4 +1,4 @@
-local helpers = require('test.unit.helpers')
+local helpers = require('test.unit.helpers')(after_each)
 local itp = helpers.gen_itp(it)
 
 local cimport = helpers.cimport
diff --git a/test/unit/os/fileio_spec.lua b/test/unit/os/fileio_spec.lua
index 9833614ca0..7a738ce85c 100644
--- a/test/unit/os/fileio_spec.lua
+++ b/test/unit/os/fileio_spec.lua
@@ -1,6 +1,6 @@
 local lfs = require('lfs')
 
-local helpers = require('test.unit.helpers')
+local helpers = require('test.unit.helpers')(after_each)
 local itp = helpers.gen_itp(it)
 
 local eq = helpers.eq
diff --git a/test/unit/os/fs_spec.lua b/test/unit/os/fs_spec.lua
index b0741c4592..1ef7d756dc 100644
--- a/test/unit/os/fs_spec.lua
+++ b/test/unit/os/fs_spec.lua
@@ -1,7 +1,7 @@
 local lfs = require('lfs')
 local bit = require('bit')
 
-local helpers = require('test.unit.helpers')
+local helpers = require('test.unit.helpers')(after_each)
 local itp = helpers.gen_itp(it)
 
 local cimport = helpers.cimport
diff --git a/test/unit/os/shell_spec.lua b/test/unit/os/shell_spec.lua
index e51be91383..de39477b19 100644
--- a/test/unit/os/shell_spec.lua
+++ b/test/unit/os/shell_spec.lua
@@ -1,4 +1,4 @@
-local helpers = require('test.unit.helpers')
+local helpers = require('test.unit.helpers')(after_each)
 local itp = helpers.gen_itp(it)
 local cimported = helpers.cimport(
   './src/nvim/os/shell.h',
diff --git a/test/unit/os/users_spec.lua b/test/unit/os/users_spec.lua
index a7ec9ab0bb..f92413c7de 100644
--- a/test/unit/os/users_spec.lua
+++ b/test/unit/os/users_spec.lua
@@ -1,4 +1,4 @@
-local helpers = require('test.unit.helpers')
+local helpers = require('test.unit.helpers')(after_each)
 local itp = helpers.gen_itp(it)
 
 local cimport = helpers.cimport
diff --git a/test/unit/path_spec.lua b/test/unit/path_spec.lua
index 45b4d117d4..9663c2c8ec 100644
--- a/test/unit/path_spec.lua
+++ b/test/unit/path_spec.lua
@@ -1,5 +1,5 @@
 local lfs = require('lfs')
-local helpers = require('test.unit.helpers')
+local helpers = require('test.unit.helpers')(after_each)
 local itp = helpers.gen_itp(it)
 
 local cimport = helpers.cimport
diff --git a/test/unit/preload.lua b/test/unit/preload.lua
index d8ec2c3943..841e19b878 100644
--- a/test/unit/preload.lua
+++ b/test/unit/preload.lua
@@ -2,6 +2,6 @@
 -- Busted started doing this to help provide more isolation.  See issue #62
 -- for more information about this.
 local ffi = require('ffi')
-local helpers = require('test.unit.helpers')
+local helpers = require('test.unit.helpers')(nil)
 local lfs = require('lfs')
 local preprocess = require('test.unit.preprocess')
diff --git a/test/unit/rbuffer_spec.lua b/test/unit/rbuffer_spec.lua
index ef838fb7c7..90ee648e7a 100644
--- a/test/unit/rbuffer_spec.lua
+++ b/test/unit/rbuffer_spec.lua
@@ -1,4 +1,4 @@
-local helpers = require("test.unit.helpers")
+local helpers = require("test.unit.helpers")(after_each)
 local itp = helpers.gen_itp(it)
 
 local ffi     = helpers.ffi
diff --git a/test/unit/strings_spec.lua b/test/unit/strings_spec.lua
index 66bc8027f0..3bc3dc7130 100644
--- a/test/unit/strings_spec.lua
+++ b/test/unit/strings_spec.lua
@@ -1,4 +1,4 @@
-local helpers = require("test.unit.helpers")
+local helpers = require("test.unit.helpers")(after_each)
 local itp = helpers.gen_itp(it)
 
 local cimport = helpers.cimport