diff options
| author | James McCoy <jamessan@jamessan.com> | 2017-08-11 10:30:38 -0400 |
|---|---|---|
| committer | James McCoy <jamessan@jamessan.com> | 2017-08-11 10:30:38 -0400 |
| commit | 9edf00bddf6802044e06bd15daad4a5735ccade8 (patch) | |
| tree | 26f42a8d349db94f9faf87846aaae116582a76e7 | |
| parent | 320b57311f155ec1c2784923994992bc79df21c6 (diff) | |
| download | rneovim-9edf00bddf6802044e06bd15daad4a5735ccade8.tar.gz rneovim-9edf00bddf6802044e06bd15daad4a5735ccade8.tar.bz2 rneovim-9edf00bddf6802044e06bd15daad4a5735ccade8.zip | |
coverity/166184: Check length of str, not term
32396b5879b429def1c48948069c55366d41b9be add length checks to
TERMINAL_FAMILY/STARTS_WITH to ensure memcmp() wouldn't read past the
end of the string. However, "term" was copy/pasted from TERMINAL_FAMILY
so STARTS_WITH() was unnecessarily reading the, potentially NULL, term
variable.
| -rw-r--r-- | src/nvim/tui/tui.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/nvim/tui/tui.c b/src/nvim/tui/tui.c index c29ec09638..97a0398c80 100644 --- a/src/nvim/tui/tui.c +++ b/src/nvim/tui/tui.c @@ -45,7 +45,7 @@ #define OUTBUF_SIZE 0xffff #define TOO_MANY_EVENTS 1000000 -#define STARTS_WITH(str, prefix) (strlen(term) >= (sizeof(prefix) - 1) \ +#define STARTS_WITH(str, prefix) (strlen(str) >= (sizeof(prefix) - 1) \ && 0 == memcmp((str), (prefix), sizeof(prefix) - 1)) #define TMUX_WRAP(is_tmux, seq) ((is_tmux) \ ? "\x1bPtmux;\x1b" seq "\x1b\\" : seq) |