diff options
| author | Eliseo Martínez <eliseomarmol@gmail.com> | 2014-04-22 11:21:23 +0200 |
|---|---|---|
| committer | Thiago de Arruda <tpadilha84@gmail.com> | 2014-04-22 16:03:21 -0300 |
| commit | a1a0c00589a8efc664db82be6743136bb462e08f (patch) | |
| tree | 56b9d1389956d28e55b7054db71c705336fa505d | |
| parent | 5f60bf4eb2ba16e012bb938a2e2b4885445afebc (diff) | |
| download | rneovim-a1a0c00589a8efc664db82be6743136bb462e08f.tar.gz rneovim-a1a0c00589a8efc664db82be6743136bb462e08f.tar.bz2 rneovim-a1a0c00589a8efc664db82be6743136bb462e08f.zip | |
Broken build on 32 bit: Fix -Wtautological-constant-out-of-range-compare.
Problem:
[ 51%] Building C object src/CMakeFiles/nvim.dir/os/rstream.c.o
/Users/eliseo/projects/os/neovim/src/os/rstream.c:237:24: error: comparison of constant
9223372036854775807 with expression of type 'size_t' (aka 'unsigned long') is always true
[-Werror,-Wtautological-constant-out-of-range-compare]
assert(rstream->fpos <= INT64_MAX);
~~~~~~~~~~~~~ ^ ~~~~~~~~~
/usr/include/assert.h:93:25: note: expanded from macro 'assert'
(__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __FILE__, __LINE__, #e) : (void)0)
^
Solution:
Assertion temporarily disabled.
TODO: Review types so that assertion can be used.
| -rw-r--r-- | src/os/rstream.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/os/rstream.c b/src/os/rstream.c index 19c18e58da..519a6466ef 100644 --- a/src/os/rstream.c +++ b/src/os/rstream.c @@ -234,7 +234,9 @@ static void fread_idle_cb(uv_idle_t *handle) // the offset argument to uv_fs_read is int64_t, could someone really try // to read more than 9 quintillion (9e18) bytes? - assert(rstream->fpos <= INT64_MAX); + // DISABLED TO FIX BROKEN BUILD ON 32bit + // TODO Review types to allow assertion + // assert(rstream->fpos <= INT64_MAX); // Synchronous read uv_fs_read( |