diff options
| author | zeertzjq <zeertzjq@outlook.com> | 2024-08-02 05:58:20 +0800 |
|---|---|---|
| committer | zeertzjq <zeertzjq@outlook.com> | 2024-08-02 06:11:58 +0800 |
| commit | a4bec30b7b2fa66a2db9d03f54e51dff58116465 (patch) | |
| tree | 0b270084a35a96524377cb7624b0dc39d90e4629 | |
| parent | 9f2d793068144ef92765fefd729b0eeffde11b7a (diff) | |
| download | rneovim-a4bec30b7b2fa66a2db9d03f54e51dff58116465.tar.gz rneovim-a4bec30b7b2fa66a2db9d03f54e51dff58116465.tar.bz2 rneovim-a4bec30b7b2fa66a2db9d03f54e51dff58116465.zip | |
vim-patch:9.0.2158: [security]: use-after-free in check_argument_type
Problem: [security]: use-after-free in check_argument_type
Solution: Reset function type pointer when freeing the function type
list
function pointer fp->uf_func_type may point to the same memory, that was
allocated for fp->uf_type_list. However, when cleaning up a function
definition (e.g. because it was invalid), fp->uf_type_list will be
freed, but fp->uf_func_type may still point to the same (now) invalid
memory address.
So when freeing the fp->uf_type_list, check if fp->func_type points to
any of those types and if it does, reset the fp->uf_func_type pointer to
the t_func_any (default) type pointer
closes: vim/vim#13652
https://github.com/vim/vim/commit/0f28791b215bd4c22ed580839409c2f7d39d8140
Co-authored-by: Christian Brabandt <cb@256bit.org>
| -rw-r--r-- | test/old/testdir/crash/poc_uaf_check_argument_types | bin | 0 -> 43 bytes | |||
| -rw-r--r-- | test/old/testdir/test_crash.vim | 6 |
2 files changed, 6 insertions, 0 deletions
diff --git a/test/old/testdir/crash/poc_uaf_check_argument_types b/test/old/testdir/crash/poc_uaf_check_argument_types Binary files differnew file mode 100644 index 0000000000..83a2e7b0a6 --- /dev/null +++ b/test/old/testdir/crash/poc_uaf_check_argument_types diff --git a/test/old/testdir/test_crash.vim b/test/old/testdir/test_crash.vim index 242da8e5db..fd786e5d54 100644 --- a/test/old/testdir/test_crash.vim +++ b/test/old/testdir/test_crash.vim @@ -184,6 +184,12 @@ func Test_crash1_3() call term_sendkeys(buf, args) call TermWait(buf, 150) + let file = 'crash/poc_uaf_check_argument_types' + let cmn_args = "%s -u NONE -i NONE -n -e -s -S %s -c ':qa!'\<cr>" + let args = printf(cmn_args, vim, file) + call term_sendkeys(buf, args) + call TermWait(buf, 150) + " clean up exe buf .. "bw!" bw! |