diff options
| author | zeertzjq <zeertzjq@outlook.com> | 2022-06-26 20:09:36 +0800 |
|---|---|---|
| committer | zeertzjq <zeertzjq@outlook.com> | 2022-06-27 05:33:54 +0800 |
| commit | bafb53604a5b03fdc319f49d5c45f71df16038c1 (patch) | |
| tree | 289f22fdf15c74b0c9713889a86b0c441cf9e692 | |
| parent | 516d6318b78c6e7f4734ea155591aa457016aa81 (diff) | |
| download | rneovim-bafb53604a5b03fdc319f49d5c45f71df16038c1.tar.gz rneovim-bafb53604a5b03fdc319f49d5c45f71df16038c1.tar.bz2 rneovim-bafb53604a5b03fdc319f49d5c45f71df16038c1.zip | |
vim-patch:8.2.3484: crash when going through spell suggestions
Problem: Crash when going through spell suggestions.
Solution: Limit the text length for finding suggestions to the original
length. Do not update buffers when exiting. (closes vim/vim#8965)
https://github.com/vim/vim/commit/e275ba4fc994474155fbafe8b87a6d3b477456ba
| -rw-r--r-- | src/nvim/spell.c | 6 | ||||
| -rw-r--r-- | src/nvim/testdir/test_spell_utf8.vim | 15 |
2 files changed, 21 insertions, 0 deletions
diff --git a/src/nvim/spell.c b/src/nvim/spell.c index 8f84204481..f5b5fe9675 100644 --- a/src/nvim/spell.c +++ b/src/nvim/spell.c @@ -3663,6 +3663,12 @@ static void suggest_try_change(suginfo_T *su) p = su->su_badptr + su->su_badlen; (void)spell_casefold(curwin, p, (int)STRLEN(p), fword + n, MAXWLEN - n); + // Make sure the resulting text is not longer than the original text. + n = (int)STRLEN(su->su_badptr); + if (n < MAXWLEN) { + fword[n] = NUL; + } + for (int lpi = 0; lpi < curwin->w_s->b_langp.ga_len; ++lpi) { lp = LANGP_ENTRY(curwin->w_s->b_langp, lpi); diff --git a/src/nvim/testdir/test_spell_utf8.vim b/src/nvim/testdir/test_spell_utf8.vim index 1d323df67e..1841289146 100644 --- a/src/nvim/testdir/test_spell_utf8.vim +++ b/src/nvim/testdir/test_spell_utf8.vim @@ -768,6 +768,21 @@ func Test_spellfile_value() set spellfile=Xdir/Xtest.utf-8.add,Xtest_other.add endfunc +func Test_no_crash_with_weird_text() + new + let lines =<< trim END + r<sfile> + + + + + END + call setline(1, lines) + exe "%norm \<C-v>ez=>\<C-v>wzG" + + bwipe! +endfunc + " Invalid bytes may cause trouble when creating the word list. func Test_check_for_valid_word() call assert_fails("spellgood! 0\xac", 'E1280:') |