diff options
| author | Jan Edmund Lazo <jan.lazo@mail.utoronto.ca> | 2019-08-23 07:24:02 -0400 |
|---|---|---|
| committer | Jan Edmund Lazo <jan.lazo@mail.utoronto.ca> | 2019-08-23 07:46:51 -0400 |
| commit | c58054c231f11cfd911795b572029e9360835bbb (patch) | |
| tree | 5a25b022f1c5b1ba8b0c83c876879b3eb700b346 | |
| parent | 7e6a2f2bedd47a2a2b3247977ef229c071225f81 (diff) | |
| download | rneovim-c58054c231f11cfd911795b572029e9360835bbb.tar.gz rneovim-c58054c231f11cfd911795b572029e9360835bbb.tar.bz2 rneovim-c58054c231f11cfd911795b572029e9360835bbb.zip | |
vim-patch:8.0.1386: cannot select modified buffers with getbufinfo()
Problem: Cannot select modified buffers with getbufinfo().
Solution: Add the "bufmodified" flag. (Yegappan Lakshmanan, closes vim/vim#2431)
https://github.com/vim/vim/commit/8e6a31df81113bbf0e4bb5324a74dc5f6c62a490
| -rw-r--r-- | runtime/doc/eval.txt | 1 | ||||
| -rw-r--r-- | src/nvim/eval.c | 8 | ||||
| -rw-r--r-- | src/nvim/testdir/test_bufwintabinfo.vim | 7 |
3 files changed, 15 insertions, 1 deletions
diff --git a/runtime/doc/eval.txt b/runtime/doc/eval.txt index 0418ab950c..8c3399fd0d 100644 --- a/runtime/doc/eval.txt +++ b/runtime/doc/eval.txt @@ -4041,6 +4041,7 @@ getbufinfo([{dict}]) be specified in {dict}: buflisted include only listed buffers. bufloaded include only loaded buffers. + bufmodified include only modified buffers. Otherwise, {expr} specifies a particular buffer to return information for. For the use of {expr}, see |bufname()| diff --git a/src/nvim/eval.c b/src/nvim/eval.c index 42fe1c04aa..94f559c0dc 100644 --- a/src/nvim/eval.c +++ b/src/nvim/eval.c @@ -9692,6 +9692,7 @@ static void f_getbufinfo(typval_T *argvars, typval_T *rettv, FunPtr fptr) bool filtered = false; bool sel_buflisted = false; bool sel_bufloaded = false; + bool sel_bufmodified = false; tv_list_alloc_ret(rettv, kListLenMayKnow); @@ -9713,6 +9714,10 @@ static void f_getbufinfo(typval_T *argvars, typval_T *rettv, FunPtr fptr) if (di != NULL && tv_get_number(&di->di_tv)) { sel_bufloaded = true; } + di = tv_dict_find(sel_d, S_LEN("bufmodified")); + if (di != NULL && tv_get_number(&di->di_tv)) { + sel_bufmodified = true; + } } } else if (argvars[0].v_type != VAR_UNKNOWN) { // Information about one buffer. Argument specifies the buffer @@ -9732,7 +9737,8 @@ static void f_getbufinfo(typval_T *argvars, typval_T *rettv, FunPtr fptr) continue; } if (filtered && ((sel_bufloaded && buf->b_ml.ml_mfp == NULL) - || (sel_buflisted && !buf->b_p_bl))) { + || (sel_buflisted && !buf->b_p_bl) + || (sel_bufmodified && !buf->b_changed))) { continue; } diff --git a/src/nvim/testdir/test_bufwintabinfo.vim b/src/nvim/testdir/test_bufwintabinfo.vim index a6b4524cc0..d88b061ac7 100644 --- a/src/nvim/testdir/test_bufwintabinfo.vim +++ b/src/nvim/testdir/test_bufwintabinfo.vim @@ -20,6 +20,13 @@ function Test_getbufwintabinfo() call assert_equal('vim', l[0].variables.editor) call assert_notequal(-1, index(l[0].windows, bufwinid('%'))) + " Test for getbufinfo() with 'bufmodified' + call assert_equal(0, len(getbufinfo({'bufmodified' : 1}))) + call setbufline('Xtestfile1', 1, ["Line1"]) + let l = getbufinfo({'bufmodified' : 1}) + call assert_equal(1, len(l)) + call assert_equal(bufnr('Xtestfile1'), l[0].bufnr) + if has('signs') call append(0, ['Linux', 'Windows', 'Mac']) sign define Mark text=>> texthl=Search |