diff options
author | luukvbaal <luukvbaal@gmail.com> | 2024-03-20 14:59:04 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-03-20 21:59:04 +0800 |
commit | c72d877c3374796a1e4b71481503225d59a9afc7 (patch) | |
tree | c4b42e87537ff7bf8b1b2e4e900319648e20404c | |
parent | 7549845e8d3fa809da659b72c3ee773d1c34118a (diff) | |
download | rneovim-c72d877c3374796a1e4b71481503225d59a9afc7.tar.gz rneovim-c72d877c3374796a1e4b71481503225d59a9afc7.tar.bz2 rneovim-c72d877c3374796a1e4b71481503225d59a9afc7.zip |
fix(cmdline): wrong 'incsearch' highlighting after :redraw (#27947)
Problem: Calling :redraw from a timer callback clears 'incsearch' highlighting.
Solution: Re-apply 'incsearch' highlighting if the screen was updated.
-rw-r--r-- | src/nvim/ex_getln.c | 5 | ||||
-rw-r--r-- | test/functional/ui/searchhl_spec.lua | 14 |
2 files changed, 19 insertions, 0 deletions
diff --git a/src/nvim/ex_getln.c b/src/nvim/ex_getln.c index d482f9851e..e5d82cc126 100644 --- a/src/nvim/ex_getln.c +++ b/src/nvim/ex_getln.c @@ -1167,6 +1167,7 @@ static int command_line_execute(VimState *state, int key) return -1; // get another key } + disptick_T display_tick_saved = display_tick; CommandLineState *s = (CommandLineState *)state; s->c = key; @@ -1178,6 +1179,10 @@ static int command_line_execute(VimState *state, int key) } else { map_execute_lua(false); } + // Re-apply 'incsearch' highlighting in case it was cleared. + if (display_tick > display_tick_saved && s->is_state.did_incsearch) { + may_do_incsearch_highlighting(s->firstc, s->count, &s->is_state); + } // nvim_select_popupmenu_item() can be called from the handling of // K_EVENT, K_COMMAND, or K_LUA. diff --git a/test/functional/ui/searchhl_spec.lua b/test/functional/ui/searchhl_spec.lua index a05436cf55..a702de5dc7 100644 --- a/test/functional/ui/searchhl_spec.lua +++ b/test/functional/ui/searchhl_spec.lua @@ -674,4 +674,18 @@ describe('search highlighting', function() :%g@a/b^ | ]]) end) + + it('incsearch is still visible after :redraw from K_EVENT', function() + fn.setline(1, { 'foo', 'bar' }) + feed('/foo<CR>/bar') + screen:expect([[ + foo | + {3:bar} | + {1:~ }|*4 + /bar^ | + ]]) + command('redraw!') + -- There is an intermediate state where :redraw! removes 'incsearch' highlight. + screen:expect_unchanged(true) + end) end) |