diff options
| author | dundargoc <33953936+dundargoc@users.noreply.github.com> | 2023-06-06 19:19:00 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-06 19:19:00 +0200 |
| commit | 0370e4def0c0328f8cd09f02c1ca82ed491ecb9a (patch) | |
| tree | 467e99961bc766b1c72a49f1a0f6540c9ddcd8d2 /cmake.packaging | |
| parent | fcfe535e9877cfdc824dc78f2d19e590400d34cd (diff) | |
| download | rneovim-0370e4def0c0328f8cd09f02c1ca82ed491ecb9a.tar.gz rneovim-0370e4def0c0328f8cd09f02c1ca82ed491ecb9a.tar.bz2 rneovim-0370e4def0c0328f8cd09f02c1ca82ed491ecb9a.zip | |
build!: remove neovim qt
Neovim QT was originally bundled on Windows as a response to the then
lackluster terminal options. The situation has dramatically changed,
with viable options such as Windows terminal, Alacritty and Wezterm to
name a few. The Windows build no longer needs this special treatment for
neovim to be usable.
Pros:
- Release builds will be smaller.
- Less maintenance burden.
- Clearer separation of responsibility (neovim issues go to the neovim
repo and neovim-qt issues to the neovim-qt repo).
- More consistent treatment between platforms.
Cons:
- Users who've come to expect neovim-qt to be bundled with nvim will
need to adjust and download neovim-qt from
https://github.com/equalsraf/neovim-qt instead.
- Similarly, build scripts will need to be adjusted to reflect this
change.
Closes https://github.com/neovim/neovim/issues/21209.
Diffstat (limited to 'cmake.packaging')
| -rw-r--r-- | cmake.packaging/CMakeLists.txt | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/cmake.packaging/CMakeLists.txt b/cmake.packaging/CMakeLists.txt index cf7196fd6e..fa815da7f9 100644 --- a/cmake.packaging/CMakeLists.txt +++ b/cmake.packaging/CMakeLists.txt @@ -37,8 +37,7 @@ if(WIN32) # Create start menu and desktop shortcuts set(CPACK_WIX_PROGRAM_MENU_FOLDER "${CPACK_PACKAGE_NAME}") - set(CPACK_PACKAGE_EXECUTABLES "nvim" "Neovim" "nvim-qt" "Neovim Qt") - set(CPACK_CREATE_DESKTOP_LINKS "nvim-qt") + set(CPACK_PACKAGE_EXECUTABLES "nvim" "Neovim") # We use a wix patch to add further options to the installer. # See: https://cmake.org/cmake/help/v3.7/module/CPackWIX.html#variable:CPACK_WIX_PATCH_FILE |