diff options
| author | zeertzjq <zeertzjq@outlook.com> | 2025-02-05 07:06:33 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-02-05 07:06:33 +0800 |
| commit | 1deb580977f4144ff3e4704765d13684e84405c5 (patch) | |
| tree | cab8cc404eb779d5346c3251a30adf5d56390085 /runtime/doc | |
| parent | 4317d366691b057ffba4504c1167128a66e4e5c8 (diff) | |
| download | rneovim-1deb580977f4144ff3e4704765d13684e84405c5.tar.gz rneovim-1deb580977f4144ff3e4704765d13684e84405c5.tar.bz2 rneovim-1deb580977f4144ff3e4704765d13684e84405c5.zip | |
vim-patch:9.1.1076: vim_strnchr() is strange and unnecessary (#32327)
Problem: vim_strnchr() is strange and unnecessary (after v9.1.1009)
Solution: Remove vim_strnchr() and use memchr() instead. Also remove a
comment referencing an #if that is no longer present.
vim_strnchr() is strange in several ways:
- It's named like vim_strchr(), but unlike vim_strchr() it doesn't
support finding a multibyte char.
- Its logic is similar to vim_strbyte(), but unlike vim_strbyte() it
uses char instead of char_u.
- It takes a pointer as its size argument, which isn't convenient for
all its callers.
- It allows embedded NULs, unlike other "strn*" functions which stop
when encountering a NUL byte.
In comparison, memchr() also allows embedded NULs, and it converts bytes
in the string to (unsigned char).
closes: vim/vim#16579
https://github.com/vim/vim/commit/34e1e8de91ff4a8922d454e3147ea425784aa0a0
Diffstat (limited to 'runtime/doc')
| -rw-r--r-- | runtime/doc/dev_vimpatch.txt | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/runtime/doc/dev_vimpatch.txt b/runtime/doc/dev_vimpatch.txt index 0ddfc75a4c..76be24878a 100644 --- a/runtime/doc/dev_vimpatch.txt +++ b/runtime/doc/dev_vimpatch.txt @@ -184,7 +184,6 @@ information. mch_memmove memmove vim_memset copy_chars copy_spaces memset vim_strbyte strchr - vim_strnchr strnchr vim_strncpy strncpy xstrlcpy/xmemcpyz vim_strcat strncat xstrlcat VIM_ISWHITE ascii_iswhite |