diff options
| author | Christian Clason <c.clason@uni-graz.at> | 2024-01-15 11:12:32 +0100 |
|---|---|---|
| committer | Christian Clason <c.clason@uni-graz.at> | 2024-01-15 11:40:44 +0100 |
| commit | 7ed69660237bd052d11af454503a986c22c507a7 (patch) | |
| tree | 6cab9ce97d1e783d0d2db52d5657b5c8b529d586 /runtime/ftplugin/sh.vim | |
| parent | fa836cb98b54dd170db485529cbeddb43c307ee1 (diff) | |
| download | rneovim-7ed69660237bd052d11af454503a986c22c507a7.tar.gz rneovim-7ed69660237bd052d11af454503a986c22c507a7.tar.bz2 rneovim-7ed69660237bd052d11af454503a986c22c507a7.zip | |
vim-patch:93197fde0f1d
runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Problem: The "*.*" browsefilter pattern only matches all files on
Windows (Daryl Lee)
Solution: Use "*" to filter on all platforms but keep "*.*" as the label
text on Windows. (Fixes vim/vim#12685, Doug Kearns)
The *.* browsefilter pattern used to match "All Files" on Windows is a
legacy of the DOS 8.3 filename wildcard matching algorithm. For reasons
of backward compatibility this still works on Windows to match all
files, even those without an extension.
However, this pattern only matches filenames containing a dot on other
platforms. This often makes files without an extension difficult to
access from the file dialog, e.g., "Makefile"
On Windows it is still standard practice to use "*.*" for the filter
label so ftplugins should use "All Files (*.*)" on Windows and "All
Files (*)" on other platforms. This matches Vim's default browsefilter
values.
This commit also normalises the browsefilter conditional test to check
for the Win32 and GTK GUI features and an unset b:browsefilter.
closes: vim/vim#12759
https://github.com/vim/vim/commit/93197fde0f1db09b1e495cf3eb14a8f42c318b80
Co-authored-by: Doug Kearns <dougkearns@gmail.com>
Diffstat (limited to 'runtime/ftplugin/sh.vim')
| -rw-r--r-- | runtime/ftplugin/sh.vim | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/runtime/ftplugin/sh.vim b/runtime/ftplugin/sh.vim index c1a6bc5ade..fccfe4be91 100644 --- a/runtime/ftplugin/sh.vim +++ b/runtime/ftplugin/sh.vim @@ -4,7 +4,7 @@ " Previous Maintainer: Dan Sharp " Contributor: Enno Nagel <ennonagel+vim@gmail.com> " Eisuke Kawashima -" Last Change: 2023 Sep 28 +" Last Change: 2024 Jan 14 if exists("b:did_ftplugin") finish @@ -33,10 +33,14 @@ if exists("loaded_matchit") && !exists("b:match_words") endif if (has("gui_win32") || has("gui_gtk")) && !exists("b:browsefilter") - let b:browsefilter = "Bourne Shell Scripts (*.sh)\t*.sh\n" .. - \ "Korn Shell Scripts (*.ksh)\t*.ksh\n" .. - \ "Bash Shell Scripts (*.bash)\t*.bash\n" .. - \ "All Files (*.*)\t*.*\n" + let b:browsefilter = "Bourne Shell Scripts (*.sh)\t*.sh\n" .. + \ "Korn Shell Scripts (*.ksh)\t*.ksh\n" .. + \ "Bash Shell Scripts (*.bash)\t*.bash\n" + if has("win32") + let b:browsefilter ..= "All Files (*.*)\t*\n" + else + let b:browsefilter ..= "All Files (*)\t*\n" + endif let b:undo_ftplugin ..= " | unlet! b:browsefilter" endif |