refactor: create function for deferred loading

The benefit of this is that users only pay for what they use. If e.g.
only `vim.lsp.buf_get_clients()` is called then they don't need to load
all modules under `vim.lsp` which could lead to significant startuptime
saving.

Also `vim.lsp.module` is a bit nicer to user compared to
`require("vim.lsp.module")`.

This isn't used for some nested modules such as `filetype` as it breaks
tests with error messages such as "attempt to index field 'detect'".
It's not entirely certain the reason for this, but it is likely it is
due to filetype being precompiled which would imply deferred loading
isn't needed for performance reasons.

1 files changed, 2 insertions, 2 deletions

diff --git a/runtime/lua/provider/python/health.lua b/runtime/lua/provider/python/health.lua
index 8f77f1d4ba..333890b62b 100644
--- a/runtime/lua/provider/python/health.lua
+++ b/runtime/lua/provider/python/health.lua
@@ -238,7 +238,7 @@ function M.check()
   end
 
   local pythonx_warnings
-  pyname, pythonx_warnings = require('vim.provider.python').detect_by_module('neovim')
+  pyname, pythonx_warnings = vim.provider.python.detect_by_module('neovim')
 
   if not pyname then
     health.warn(
@@ -363,7 +363,7 @@ function M.check()
     -- can import 'pynvim'. If so, that Python failed to import 'neovim' as
     -- well, which is most probably due to a failed pip upgrade:
     -- https://github.com/neovim/neovim/wiki/Following-HEAD#20181118
-    local pynvim_exe = require('vim.provider.python').detect_by_module('pynvim')
+    local pynvim_exe = vim.provider.python.detect_by_module('pynvim')
     if pynvim_exe then
       local message = 'Detected pip upgrade failure: Python executable can import "pynvim" but not "neovim": '
         .. pynvim_exe