diff options
| author | Jaehwang Jung <tomtomjhj@gmail.com> | 2023-12-25 02:31:47 +0900 |
|---|---|---|
| committer | Lewis Russell <me@lewisr.dev> | 2024-01-04 11:37:00 +0000 |
| commit | dc48a98f9ac614dc94739637c967aa29e064807e (patch) | |
| tree | b53348803c82a132b51077eca3200f3aa36cc513 /runtime/lua/vim/_meta/api.lua | |
| parent | 9b90657376754a492d19f1daaffb257bf87d09cf (diff) | |
| download | rneovim-dc48a98f9ac614dc94739637c967aa29e064807e.tar.gz rneovim-dc48a98f9ac614dc94739637c967aa29e064807e.tar.bz2 rneovim-dc48a98f9ac614dc94739637c967aa29e064807e.zip | |
fix(decorations): validate botline for on_win
Problem:
Many decoration providers (treesitter injection highlighting, semantic
token highlighting, inlay hint) rely on the correctness of the `botline`
argument of `on_win` callback. However, `botline` can be smaller than
the actual line number of the last displayed line if some lines are
folded. In such cases, some decorations will be missing in the lines not
covered by `botline`.
Solution:
Validate `botline` when invoking `on_win`.
NOTE:
It seems that the old code was deliberately avoiding this presumably due
to performance reasons. However, I haven't experienced noticeable lag
after this change, and I believe the cost of botline computation would
be much smaller than the cost of decoration providers.
Diffstat (limited to 'runtime/lua/vim/_meta/api.lua')
| -rw-r--r-- | runtime/lua/vim/_meta/api.lua | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/runtime/lua/vim/_meta/api.lua b/runtime/lua/vim/_meta/api.lua index c0dfa7635b..02128b66b9 100644 --- a/runtime/lua/vim/_meta/api.lua +++ b/runtime/lua/vim/_meta/api.lua @@ -1761,9 +1761,7 @@ function vim.api.nvim_set_current_win(window) end --- • on_buf: called for each buffer being redrawn (before window --- callbacks) ["buf", bufnr, tick] --- • on_win: called when starting to redraw a specific window. ---- botline_guess is an approximation that does not exceed the ---- last line number. ["win", winid, bufnr, topline, ---- botline_guess] +--- ["win", winid, bufnr, topline, botline] --- • on_line: called for each buffer line being redrawn. (The --- interaction with fold lines is subject to change) ["win", --- winid, bufnr, row] |