diff options
author | Jon Huhn <nojnhuh@users.noreply.github.com> | 2024-06-10 06:23:03 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-06-10 04:23:03 -0700 |
commit | 4bd86120d41e3b01433004bf761beccb7f3a0167 (patch) | |
tree | 8d23c40446d5a70e0f711c147cc2c2ea30884364 /runtime/lua/vim/_meta/builtin.lua | |
parent | 743c5808b616daece73145ddd12b39ae07bbd87a (diff) | |
download | rneovim-4bd86120d41e3b01433004bf761beccb7f3a0167.tar.gz rneovim-4bd86120d41e3b01433004bf761beccb7f3a0167.tar.bz2 rneovim-4bd86120d41e3b01433004bf761beccb7f3a0167.zip |
fix(glob): handle overlapping `{}` condition elements #29236
This change fixes an issue where glob patterns like `{a,ab}` would not
match `ab` because the first option `a` matches, then the end of the
string is expected but `b` is found, and LPeg does not backtrack to try
the next option `ab` which would match. The fix here is to also append
the rest of the pattern to the generated LPeg pattern for each option.
This changes a glob `{a,ab}` from being parsed as
("a" or "ab") "end of string"
to
("a" "end of string" or "ab" "end of string")
Here, matching against `ab` would try the first option, fail to match,
then proceed to the next option, and match.
The sacrifice this change makes is dropping support for nested `{}`
conditions, which VSCode doesn't seem to support or test AFAICT.
Fixes #28931
Co-authored-by: Sergey Slipchenko <faergeek@gmail.com>
Diffstat (limited to 'runtime/lua/vim/_meta/builtin.lua')
0 files changed, 0 insertions, 0 deletions