diff options
| author | Justin M. Keyes <justinkz@gmail.com> | 2024-04-25 04:15:58 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-25 04:15:58 -0700 |
| commit | e0d92b9cc20b58179599f53dfa74ca821935a539 (patch) | |
| tree | 29c8f5c83f2c2935c87036f7a57ff806354b4ec4 /runtime/lua/vim/lsp/handlers.lua | |
| parent | a1c2da56ecef9c7a0e17be02f587d7c7f9eee170 (diff) | |
| download | rneovim-e0d92b9cc20b58179599f53dfa74ca821935a539.tar.gz rneovim-e0d92b9cc20b58179599f53dfa74ca821935a539.tar.bz2 rneovim-e0d92b9cc20b58179599f53dfa74ca821935a539.zip | |
fix(vim.ui)!: change open() to return pcall-like values #28502
Problem:
`vim.ui.open` unnecessarily invents a different success/failure
convention. Its return type was changed in 57adf8c6e01d, so we might as
well change it to have a more conventional form.
Solution:
Change the signature to use the `pcall` convention of `status, result`.
Diffstat (limited to 'runtime/lua/vim/lsp/handlers.lua')
| -rw-r--r-- | runtime/lua/vim/lsp/handlers.lua | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/runtime/lua/vim/lsp/handlers.lua b/runtime/lua/vim/lsp/handlers.lua index 4672d94105..ab4fa52c40 100644 --- a/runtime/lua/vim/lsp/handlers.lua +++ b/runtime/lua/vim/lsp/handlers.lua @@ -654,15 +654,15 @@ M[ms.window_showDocument] = function(_, result, ctx, _) if result.external then -- TODO(lvimuser): ask the user for confirmation - local cmd, err = vim.ui.open(uri) - local ret = cmd and cmd:wait(2000) or nil + local ok, cmd_or_err = vim.ui.open(uri) + local ret = ok and (cmd_or_err --[[@as vim.SystemObj]]):wait(2000) or nil if ret == nil or ret.code ~= 0 then return { success = false, error = { code = protocol.ErrorCodes.UnknownErrorCode, - message = ret and ret.stderr or err, + message = ret and ret.stderr or cmd_or_err, }, } end |