diff options
author | zeertzjq <zeertzjq@outlook.com> | 2025-03-09 08:00:53 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-03-09 08:00:53 +0800 |
commit | 8ea18119e7bbbf956680266b6e1a69bc5fa4b40d (patch) | |
tree | 91101e0d0fee56dc6552beda3e922810d8775c9a /runtime/lua/vim/snippet.lua | |
parent | e02ee7410a6d04b32ec38af9f4ffdcf0798a0f0b (diff) | |
download | rneovim-8ea18119e7bbbf956680266b6e1a69bc5fa4b40d.tar.gz rneovim-8ea18119e7bbbf956680266b6e1a69bc5fa4b40d.tar.bz2 rneovim-8ea18119e7bbbf956680266b6e1a69bc5fa4b40d.zip |
vim-patch:9.1.1184: Unnecessary use of vim_tolower() in vim_strnicmp_asc() (#32792)
Problem: Unnecessary use of vim_tolower() in vim_strnicmp_asc().
Solution: Use TOLOWER_ASC() instead (zeertzjq).
It was passing *s1 and *s2 to vim_tolower(). When char is signed, which
is the case on most platforms, c < 0x80 is always true, so it already
behaves the same as TOLOWER_ASC().
closes: vim/vim#16826
https://github.com/vim/vim/commit/b7dc5d3b6169efc8aa0b9d86476072877e74bc2c
Use this function for hashy case-insensitive lookup, as it's ASCII-only.
Note that this function doesn't cast TOLOWER_ASC() argument to uint8_t,
so it'll treat a UTF-8 byte as smaller than NUL. It doesn't matter, as
one of the strings being compared is ASCII-only, and its behavior still
leads to consistent ordering.
Diffstat (limited to 'runtime/lua/vim/snippet.lua')
0 files changed, 0 insertions, 0 deletions