diff options
author | Justin M. Keyes <justinkz@gmail.com> | 2024-12-16 04:00:20 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-12-16 04:00:20 -0800 |
commit | 167a2383b9966ac227a77b0221088246e14ce75a (patch) | |
tree | d509817042d19ba96a3305abdc62f1f7a67054ab /src/nvim/api/window.c | |
parent | 9c6a3703bb15d56fecdd962512f69f0ccf6d398c (diff) | |
download | rneovim-167a2383b9966ac227a77b0221088246e14ce75a.tar.gz rneovim-167a2383b9966ac227a77b0221088246e14ce75a.tar.bz2 rneovim-167a2383b9966ac227a77b0221088246e14ce75a.zip |
fix(api): not using TRY_WRAP, generic error messages #31595
Problem:
- API functions using `try_start` directly instead of `TRY_WRAP`, do not
surface the underlying error message, and instead show generic things
like "Failed to set buffer".
- Error handling code is duplicated in the API impl, instead of
delegating to the vim buffer/window handling logic.
Solution:
- Use `TRY_WRAP`.
Diffstat (limited to 'src/nvim/api/window.c')
-rw-r--r-- | src/nvim/api/window.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/src/nvim/api/window.c b/src/nvim/api/window.c index f415415fa7..170d5c6cdb 100644 --- a/src/nvim/api/window.c +++ b/src/nvim/api/window.c @@ -59,12 +59,7 @@ void nvim_win_set_buf(Window window, Buffer buffer, Error *err) { win_T *win = find_window_by_handle(window, err); buf_T *buf = find_buffer_by_handle(buffer, err); - if (!win || !buf || win->w_buffer == buf) { - return; - } - - if (win->w_p_wfb) { - api_set_error(err, kErrorTypeException, "%s", e_winfixbuf_cannot_go_to_buffer); + if (!win || !buf) { return; } |