aboutsummaryrefslogtreecommitdiff
path: root/src/nvim/diff.c
diff options
context:
space:
mode:
authorSean Dewar <6256228+seandewar@users.noreply.github.com>2024-03-13 22:06:39 +0000
committerGitHub <noreply@github.com>2024-03-13 22:06:39 +0000
commitbbb68e2a034ad3aaea99178c09301ca458ee8dff (patch)
treeb58d044908487e8cb174a0669f2e36890685f534 /src/nvim/diff.c
parent2a8cef6bd450febd88d754e0c1909137b7451757 (diff)
downloadrneovim-bbb68e2a034ad3aaea99178c09301ca458ee8dff.tar.gz
rneovim-bbb68e2a034ad3aaea99178c09301ca458ee8dff.tar.bz2
rneovim-bbb68e2a034ad3aaea99178c09301ca458ee8dff.zip
vim-patch:9.1.0175: wrong window positions with 'winfix{width,height}' (#27845)
Problem: winframe functions incorrectly recompute window positions if the altframe wasn't adjacent to the closed frame, which is possible if adjacent windows had 'winfix{width,height}' set. Solution: recompute for windows within the parent of the altframe and closed frame. Skip this (as before) if the altframe was top/left, but only if adjacent to the closed frame, as positions won't change in that case. Also correct the return value documentation for win_screenpos. (Sean Dewar) The issue revealed itself after removing the win_comp_pos call below winframe_restore in win_splitmove. Similarly, wrong positions could result from windows closed in other tabpages, as win_free_mem uses winframe_remove (at least until it is entered later, where enter_tabpage calls win_comp_pos). NOTE: As win_comp_pos handles only curtab, it's possible via other means for positions in non-current tabpages to be wrong (e.g: after changing 'laststatus', 'showtabline', etc.). Given enter_tabpage recomputes it, maybe it's intentional as an optimization? Should probably be documented in win_screenpos then, but I won't address that here. closes: vim/vim#14191 Nvim: don't reuse "wp" for "topleft" in winframe_remove, so the change integrates better with the call to winframe_find_altwin before it. https://github.com/vim/vim/commit/5866bc3a0f54115d5982fdc09bdbe4c45069265a
Diffstat (limited to 'src/nvim/diff.c')
0 files changed, 0 insertions, 0 deletions