diff options
| author | zeertzjq <zeertzjq@outlook.com> | 2023-01-21 09:24:09 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-01-21 09:24:09 +0800 |
| commit | e86d2734a93e159d44df8132dee6b994e5922d18 (patch) | |
| tree | e8a3015ebc88d880f9e749a7e69fbcf0d8793037 /src/nvim/eval/typval.c | |
| parent | 1c16d0994d08f1a6c396bc46833d0bfdade29422 (diff) | |
| download | rneovim-e86d2734a93e159d44df8132dee6b994e5922d18.tar.gz rneovim-e86d2734a93e159d44df8132dee6b994e5922d18.tar.bz2 rneovim-e86d2734a93e159d44df8132dee6b994e5922d18.zip | |
refactor: use uint8_t for blobs and ga_append() (#21916)
A blob is used as a sequence of bytes and usually accessed individually,
not as as a NUL-terminuated string, so uint8_t should be better.
Not sure about ga_append(), but using uint8_t leads to fewer casts.
Diffstat (limited to 'src/nvim/eval/typval.c')
| -rw-r--r-- | src/nvim/eval/typval.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/nvim/eval/typval.c b/src/nvim/eval/typval.c index 9ffc4d4696..05b4737206 100644 --- a/src/nvim/eval/typval.c +++ b/src/nvim/eval/typval.c @@ -2730,7 +2730,7 @@ void tv_blob_remove(typval_T *argvars, typval_T *rettv, const char *arg_errmsg) } if (argvars[2].v_type == VAR_UNKNOWN) { // Remove one item, return its value. - char_u *const p = (char_u *)b->bv_ga.ga_data; + uint8_t *const p = (uint8_t *)b->bv_ga.ga_data; rettv->vval.v_number = (varnumber_T)(*(p + idx)); memmove(p + idx, p + idx + 1, (size_t)(len - idx - 1)); b->bv_ga.ga_len--; @@ -2752,9 +2752,8 @@ void tv_blob_remove(typval_T *argvars, typval_T *rettv, const char *arg_errmsg) blob->bv_ga.ga_len = (int)(end - idx + 1); ga_grow(&blob->bv_ga, (int)(end - idx + 1)); - char_u *const p = (char_u *)b->bv_ga.ga_data; - memmove((char_u *)blob->bv_ga.ga_data, p + idx, - (size_t)(end - idx + 1)); + uint8_t *const p = (uint8_t *)b->bv_ga.ga_data; + memmove(blob->bv_ga.ga_data, p + idx, (size_t)(end - idx + 1)); tv_blob_set_ret(rettv, blob); if (len - end - 1 > 0) { |