diff options
| author | Justin M. Keyes <justinkz@gmail.com> | 2015-08-16 23:13:55 -0400 |
|---|---|---|
| committer | Justin M. Keyes <justinkz@gmail.com> | 2015-08-17 01:15:04 -0400 |
| commit | 8f09fa1a49ffa1fc00eabf78c54908d515d0aaa5 (patch) | |
| tree | 72117f7016f3fbfaf936ffa93745bc52c3f34b4c /src/nvim/fileio.c | |
| parent | d5cd15e67f8a4cfdc6a29d39efbce2697578783c (diff) | |
| download | rneovim-8f09fa1a49ffa1fc00eabf78c54908d515d0aaa5.tar.gz rneovim-8f09fa1a49ffa1fc00eabf78c54908d515d0aaa5.tar.bz2 rneovim-8f09fa1a49ffa1fc00eabf78c54908d515d0aaa5.zip | |
os/fs.c: remove os_file_is_readonly()
os_file_is_readonly() in its current form is equivalent to
!os_file_is_writable(). This does not appear to be a bug, because Vim's
use of check_file_readonly() (which we changed to os_file_is_readonly())
is equivalent to !os_file_is_writable() in every case.
os_file_is_readonly() also fails this test:
returns false if the file is non-read, non-write
A more useful form would define behavior under these cases:
- path is executable (but not writable)
- path is non-existent
- path is directory
But there is no reason for os_file_is_readonly() to exist, so remove it.
Diffstat (limited to 'src/nvim/fileio.c')
| -rw-r--r-- | src/nvim/fileio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/nvim/fileio.c b/src/nvim/fileio.c index c9e11d8fb5..70cdac7947 100644 --- a/src/nvim/fileio.c +++ b/src/nvim/fileio.c @@ -2623,7 +2623,7 @@ buf_write ( * Check if the file is really writable (when renaming the file to * make a backup we won't discover it later). */ - file_readonly = os_file_is_readonly((char *)fname); + file_readonly = !os_file_is_writable((char *)fname); if (!forceit && file_readonly) { if (vim_strchr(p_cpo, CPO_FWRITE) != NULL) { |