diff options
author | bfredl <bjorn.linse@gmail.com> | 2023-08-24 15:14:23 +0200 |
---|---|---|
committer | bfredl <bjorn.linse@gmail.com> | 2023-08-24 22:40:56 +0200 |
commit | cefd774fac76b91f5368833555818c80c992c3b1 (patch) | |
tree | 146d6cb8fde01d28c5b03b9640f9e2515c4a89b7 /src/nvim/fileio.c | |
parent | daf7abbc4238dc269e22dd431bc4b1627ef9b6a1 (diff) | |
download | rneovim-cefd774fac76b91f5368833555818c80c992c3b1.tar.gz rneovim-cefd774fac76b91f5368833555818c80c992c3b1.tar.bz2 rneovim-cefd774fac76b91f5368833555818c80c992c3b1.zip |
refactor(memline): distinguish mutating uses of ml_get_buf()
ml_get_buf() takes a third parameters to indicate whether the
caller wants to mutate the memline data in place. However
the vast majority of the call sites is using this function
just to specify a buffer but without any mutation. This makes
it harder to grep for the places which actually perform mutation.
Solution: Remove the bool param from ml_get_buf(). it now works
like ml_get() except for a non-current buffer. Add a new
ml_get_buf_mut() function for the mutating use-case, which can
be grepped along with the other ml_replace() etc functions which
can modify the memline.
Diffstat (limited to 'src/nvim/fileio.c')
-rw-r--r-- | src/nvim/fileio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/nvim/fileio.c b/src/nvim/fileio.c index e22bb609b6..1cbfcff9f4 100644 --- a/src/nvim/fileio.c +++ b/src/nvim/fileio.c @@ -2842,7 +2842,7 @@ static int move_lines(buf_T *frombuf, buf_T *tobuf) // Copy the lines in "frombuf" to "tobuf". curbuf = tobuf; for (linenr_T lnum = 1; lnum <= frombuf->b_ml.ml_line_count; lnum++) { - char *p = xstrdup(ml_get_buf(frombuf, lnum, false)); + char *p = xstrdup(ml_get_buf(frombuf, lnum)); if (ml_append(lnum - 1, p, 0, false) == FAIL) { xfree(p); retval = FAIL; |