diff options
| author | luukvbaal <luukvbaal@gmail.com> | 2025-01-07 02:00:09 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-01-06 17:00:09 -0800 |
| commit | 06ff5480ce274daf3b7ad9950a587099200dc8ff (patch) | |
| tree | c38310cd1e5c6a25cb16cc255e818b658c5dcbc7 /src/nvim/option.c | |
| parent | 30de00687b899824bb319dfb3f7989ea3f936617 (diff) | |
| download | rneovim-06ff5480ce274daf3b7ad9950a587099200dc8ff.tar.gz rneovim-06ff5480ce274daf3b7ad9950a587099200dc8ff.tar.bz2 rneovim-06ff5480ce274daf3b7ad9950a587099200dc8ff.zip | |
vim-patch:9.1.0993: New 'cmdheight' behavior may be surprising #31892
Problem: Although patch 9.1.0990 fixed a real problem/inconsistency,
it also introduced new behavior that may break BWC and/or be
unexpected. Before 9.1.0990, window commands could make the
topframe smaller (without changing 'cmdheight'; quirk that is
now fixed), but did not allow extending the topframe beyond
the 'cmdheight' set by the user. After 9.1.0990, the user can
reduce the 'cmdheight' below the value they set explicitly,
through window commands, which may lead to confusion.
(aftere v9.1.0990)
Solution: Store the value explicitly set by the user and clamp the
'cmdheight' when resizing the topframe. This also applies to
dragging laststatus, which in contrast to window commands
_did_ allow reducing the 'cmdheight' to values below the one
set by the user. So with this patch there is still new
behavior, but I think in a way that is less surprising.
While at it, also fix a Coverity warning, introduced in
v9.1.0990 (Luuk van Baal)
https://github.com/vim/vim/commit/c97e8695353565d6b20adffa48aad47f6e09967f
Diffstat (limited to 'src/nvim/option.c')
| -rw-r--r-- | src/nvim/option.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/nvim/option.c b/src/nvim/option.c index 824c9988f4..551ea0be20 100644 --- a/src/nvim/option.c +++ b/src/nvim/option.c @@ -2872,8 +2872,6 @@ static const char *validate_num_option(OptIndex opt_idx, OptInt *newval, char *e case kOptCmdheight: if (value < 0) { return e_positive; - } else { - p_ch_was_zero = value == 0; } break; case kOptHistory: |