aboutsummaryrefslogtreecommitdiff
path: root/src/nvim/optionstr.c
diff options
context:
space:
mode:
authorLewis Russell <lewis6991@gmail.com>2023-07-12 14:54:13 +0100
committerLewis Russell <lewis6991@gmail.com>2023-08-31 15:07:05 +0100
commit354a1154423fc381dfcd7b045963e8076288e777 (patch)
tree1078966e8673e5a20859acf48afd5fda8c0bcbfa /src/nvim/optionstr.c
parent804c828e681ec3e55f19614d78c2b098b2672f86 (diff)
downloadrneovim-354a1154423fc381dfcd7b045963e8076288e777.tar.gz
rneovim-354a1154423fc381dfcd7b045963e8076288e777.tar.bz2
rneovim-354a1154423fc381dfcd7b045963e8076288e777.zip
refactor(option.c): call did_set_option for all types
set_option_value() only called did_set_option() for string options, whereas do_set_option_value() called it for all types. This change makes set_option_value() call did_set_option() for all types and thus makes it more consistent with do_set_option_value().
Diffstat (limited to 'src/nvim/optionstr.c')
-rw-r--r--src/nvim/optionstr.c9
1 files changed, 2 insertions, 7 deletions
diff --git a/src/nvim/optionstr.c b/src/nvim/optionstr.c
index 9e5226a46f..d5ab47cc84 100644
--- a/src/nvim/optionstr.c
+++ b/src/nvim/optionstr.c
@@ -428,7 +428,7 @@ void set_string_option_direct_in_buf(buf_T *buf, const char *name, int opt_idx,
///
/// @return NULL on success, an untranslated error message on error.
const char *set_string_option(const int opt_idx, const char *const value, const int opt_flags,
- char *const errbuf, const size_t errbuflen)
+ int *value_checked, char *const errbuf, const size_t errbuflen)
FUNC_ATTR_NONNULL_ARG(2) FUNC_ATTR_WARN_UNUSED_RESULT
{
vimoption_T *opt = get_option(opt_idx);
@@ -457,13 +457,8 @@ const char *set_string_option(const int opt_idx, const char *const value, const
char *const saved_oldval_g = (oldval_g != NULL) ? xstrdup(oldval_g) : 0;
char *const saved_newval = xstrdup(*varp);
- int value_checked = false;
const char *const errmsg = did_set_string_option(curbuf, curwin, opt_idx, varp, oldval, errbuf,
- errbuflen, opt_flags, &value_checked);
- if (errmsg == NULL) {
- did_set_option(opt_idx, opt_flags, true, value_checked);
- }
-
+ errbuflen, opt_flags, value_checked);
// call autocommand after handling side effects
if (errmsg == NULL) {
if (!starting) {