diff options
| author | Famiu Haque <famiuhaque@proton.me> | 2024-02-03 12:57:03 +0600 |
|---|---|---|
| committer | Famiu Haque <famiuhaque@proton.me> | 2024-03-21 15:41:14 +0600 |
| commit | 2214f9c19daa46a1fc37bcc14c017c092894a506 (patch) | |
| tree | 5fd933cd67d5d868a4c876dcc20af263e3d4ddfc /src/nvim/popupmenu.c | |
| parent | 5aa8c02a9de5c1efa1e2dee60af1ecf58f452d19 (diff) | |
| download | rneovim-2214f9c19daa46a1fc37bcc14c017c092894a506.tar.gz rneovim-2214f9c19daa46a1fc37bcc14c017c092894a506.tar.bz2 rneovim-2214f9c19daa46a1fc37bcc14c017c092894a506.zip | |
refactor(options): remove `set_string_option_direct()`
Problem: `set_string_option_direct()` contains a separate codepath specifically for setting string options. Not only is that unnecessary code duplication, but it's also limited to only string options.
Solution: Replace `set_string_option_direct()` with `set_option_direct()` which calls `set_option()` under the hood. This reduces code duplication and allows directly setting an option of any type.
Diffstat (limited to 'src/nvim/popupmenu.c')
| -rw-r--r-- | src/nvim/popupmenu.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/nvim/popupmenu.c b/src/nvim/popupmenu.c index 5e8fb7f5de..bed0a8df4a 100644 --- a/src/nvim/popupmenu.c +++ b/src/nvim/popupmenu.c @@ -704,7 +704,8 @@ static win_T *pum_create_float_preview(bool enter) return NULL; } buf_T *buf = find_buffer_by_handle(b, &err); - set_string_option_direct_in_buf(buf, kOptBufhidden, "wipe", OPT_LOCAL, 0); + set_option_direct_for(kOptBufhidden, STATIC_CSTR_AS_OPTVAL("wipe"), OPT_LOCAL, 0, kOptReqBuf, + buf); wp->w_float_is_info = true; wp->w_p_diff = false; buf->b_p_bl = false; |