diff options
| author | Dundar Goc <gocdundar@gmail.com> | 2022-05-07 12:53:37 +0200 |
|---|---|---|
| committer | Dundar Goc <gocdundar@gmail.com> | 2022-06-10 16:16:41 +0200 |
| commit | a732c253b71f89702285d5ec6fd7803045f6add9 (patch) | |
| tree | cd6b0dbad292dcbfaae637ffad385298594a2ff2 /src/nvim/popupmnu.c | |
| parent | e15d31b530c443daea04d7a772b24da737397c53 (diff) | |
| download | rneovim-a732c253b71f89702285d5ec6fd7803045f6add9.tar.gz rneovim-a732c253b71f89702285d5ec6fd7803045f6add9.tar.bz2 rneovim-a732c253b71f89702285d5ec6fd7803045f6add9.zip | |
refactor: change type of linenr_T from long to int32_t
The size of long varies depending on architecture, in contrast to the
MAXLNUM constant which sets the maximum allowable number of lines to
2^32-1. This discrepancy may lead to hard to detect bugs, for example
https://github.com/neovim/neovim/issues/18454. Setting linenr_T to a
fix maximum size of 2^32-1 will prevent this type of errors in the
future.
Also change the variables `amount` and `amount_after` to be linenr_T
since they're referring to "the line number difference" between two
texts.
Diffstat (limited to 'src/nvim/popupmnu.c')
| -rw-r--r-- | src/nvim/popupmnu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/nvim/popupmnu.c b/src/nvim/popupmnu.c index a77463c9ca..7233a3bb72 100644 --- a/src/nvim/popupmnu.c +++ b/src/nvim/popupmnu.c @@ -763,7 +763,7 @@ static int pum_set_selected(int n, int repeat) // text, but no more than 'previewheight' lines. if (repeat == 0) { if (lnum > p_pvh) { - lnum = p_pvh; + lnum = (linenr_T)p_pvh; } if (curwin->w_height < lnum) { |