diff options
| author | Jan Edmund Lazo <jan.lazo@mail.utoronto.ca> | 2021-05-19 21:06:49 -0400 |
|---|---|---|
| committer | Jan Edmund Lazo <jan.lazo@mail.utoronto.ca> | 2021-05-19 21:09:53 -0400 |
| commit | 49ab1b91e7cccb4fc5edad6d2fa8c547fb38942b (patch) | |
| tree | d8df645e9f993a6903dda09fdf5d24c45680850b /src/nvim/quickfix.c | |
| parent | 003cda23123e98824ccc8f7467cf6800a8e75961 (diff) | |
| download | rneovim-49ab1b91e7cccb4fc5edad6d2fa8c547fb38942b.tar.gz rneovim-49ab1b91e7cccb4fc5edad6d2fa8c547fb38942b.tar.bz2 rneovim-49ab1b91e7cccb4fc5edad6d2fa8c547fb38942b.zip | |
Remove '- 1' for sizes passed to xstrlcpy
xstrlcpy() NUL-terminates the destination string
such that reducing the destination string length by 1
to reserve the last byte for NUL is pointless.
https://github.com/neovim/neovim/pull/14490#discussion_r635661185
Diffstat (limited to 'src/nvim/quickfix.c')
| -rw-r--r-- | src/nvim/quickfix.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/nvim/quickfix.c b/src/nvim/quickfix.c index 464d72eccb..e318e9a078 100644 --- a/src/nvim/quickfix.c +++ b/src/nvim/quickfix.c @@ -3919,13 +3919,13 @@ static int qf_buf_add_line(buf_T *buf, linenr_T lnum, const qfline_T *qfp, buf_T *errbuf; if (qfp->qf_module != NULL) { - STRLCPY(IObuff, qfp->qf_module, IOSIZE - 1); + STRLCPY(IObuff, qfp->qf_module, IOSIZE); len = (int)STRLEN(IObuff); } else if (qfp->qf_fnum != 0 && (errbuf = buflist_findnr(qfp->qf_fnum)) != NULL && errbuf->b_fname != NULL) { if (qfp->qf_type == 1) { // :helpgrep - STRLCPY(IObuff, path_tail(errbuf->b_fname), IOSIZE - 1); + STRLCPY(IObuff, path_tail(errbuf->b_fname), IOSIZE); } else { // Shorten the file name if not done already. // For optimization, do this only for the first entry in a @@ -3938,7 +3938,7 @@ static int qf_buf_add_line(buf_T *buf, linenr_T lnum, const qfline_T *qfp, } shorten_buf_fname(errbuf, dirname, false); } - STRLCPY(IObuff, errbuf->b_fname, IOSIZE - 1); + STRLCPY(IObuff, errbuf->b_fname, IOSIZE); } len = (int)STRLEN(IObuff); } else { |