aboutsummaryrefslogtreecommitdiff
path: root/src/nvim/shada.c
diff options
context:
space:
mode:
authorbfredl <bjorn.linse@gmail.com>2024-02-18 12:51:27 +0100
committerbfredl <bjorn.linse@gmail.com>2024-02-18 18:09:56 +0100
commitbbf6d4a4bc44c8e61f807d23cc4ff2c2683e1ef4 (patch)
tree902bafe780724ed393af753bbf4c5c346fbb84a9 /src/nvim/shada.c
parent93c911e52feadff72003f7e78257c00c3bbf1570 (diff)
downloadrneovim-bbf6d4a4bc44c8e61f807d23cc4ff2c2683e1ef4.tar.gz
rneovim-bbf6d4a4bc44c8e61f807d23cc4ff2c2683e1ef4.tar.bz2
rneovim-bbf6d4a4bc44c8e61f807d23cc4ff2c2683e1ef4.zip
refactor(api): use arena for metadata; msgpack_rpc_to_object delenda est
Note: kSDItemHeader is something is _written_ by nvim in the shada file to identify it for debugging purposes outside of nvim. But this data wasn't ever used by neovim after reading the file back, So I removed the parsing of it for now.
Diffstat (limited to 'src/nvim/shada.c')
-rw-r--r--src/nvim/shada.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/src/nvim/shada.c b/src/nvim/shada.c
index 2c8685adc7..f4a729d13d 100644
--- a/src/nvim/shada.c
+++ b/src/nvim/shada.c
@@ -3629,10 +3629,9 @@ shada_read_next_item_start:
entry->data = sd_default_values[type_u64].data;
switch ((ShadaEntryType)type_u64) {
case kSDItemHeader:
- if (!msgpack_rpc_to_dictionary(&(unpacked.data), &(entry->data.header))) {
- semsg(_(READERR("header", "is not a dictionary")), initial_fpos);
- goto shada_read_next_item_error;
- }
+ // TODO(bfredl): header is written to file and provides useful debugging
+ // info. It is never read by nvim (earlier we parsed it back to a
+ // Dictionary, but that value was never used)
break;
case kSDItemSearchPattern: {
if (unpacked.data.type != MSGPACK_OBJECT_MAP) {