refactor: clang-tidy fixes to silence clangd warning (#20683)

* refactor: readability-uppercase-literal-suffix

* refactor: readability-named-parameter

* refactor: bugprone-suspicious-string-compare

* refactor: google-readability-casting

* refactor: readability-redundant-control-flow

* refactor: bugprone-too-small-loop-variable

* refactor: readability-non-const-parameter

* refactor: readability-avoid-const-params-in-decls

* refactor: google-readability-todo

* refactor: readability-inconsistent-declaration-parameter-name

* refactor: bugprone-suspicious-missing-comma

* refactor: remove noisy or slow warnings

1 files changed, 4 insertions, 6 deletions

diff --git a/src/nvim/tag.c b/src/nvim/tag.c
index 7c465ac909..07aee92d92 100644
--- a/src/nvim/tag.c
+++ b/src/nvim/tag.c
@@ -643,8 +643,6 @@ end_do_tag:
   }
   postponed_split = 0;          // don't split next time
   g_do_tagpreview = 0;          // don't do tag preview next time
-
-  return;
 }
 
 // List all the matching tags.
@@ -1495,7 +1493,7 @@ int find_tags(char *pat, int *num_matches, char ***matchesp, int flags, int minc
 
     // Try tag file names from tags option one by one.
     for (first_file = true;
-         get_tagfname(&tn, first_file, (char *)tag_fname) == OK;
+         get_tagfname(&tn, first_file, tag_fname) == OK;
          first_file = false) {
       // A file that doesn't exist is silently ignored.  Only when not a
       // single file is found, an error message is given (further on).
@@ -1553,7 +1551,7 @@ int find_tags(char *pat, int *num_matches, char ***matchesp, int flags, int minc
         }
       }
 
-      if ((fp = os_fopen((char *)tag_fname, "r")) == NULL) {
+      if ((fp = os_fopen(tag_fname, "r")) == NULL) {
         continue;
       }
 
@@ -1647,7 +1645,7 @@ int find_tags(char *pat, int *num_matches, char ***matchesp, int flags, int minc
           // skip empty and blank lines
           do {
             eof = vim_fgets((char_u *)lbuf, lbuf_size, fp);
-          } while (!eof && vim_isblankline((char *)lbuf));
+          } while (!eof && vim_isblankline(lbuf));
 
           if (eof) {
             break;                                  // end of file
@@ -1953,7 +1951,7 @@ parse_line:
 
           // Decide in which array to store this match.
           is_current = test_for_current((char *)tagp.fname, (char *)tagp.fname_end,
-                                        (char *)tag_fname,
+                                        tag_fname,
                                         buf_ffname);
           is_static = test_for_static(&tagp);