Merge #10869 'vim-patch:8.1.{0309,0362,0365,0515,1946}'

1 files changed, 295 insertions, 39 deletions

diff --git a/src/nvim/testdir/test_profile.vim b/src/nvim/testdir/test_profile.vim
index 9b78d90b0b..7e853eeac3 100644
--- a/src/nvim/testdir/test_profile.vim
+++ b/src/nvim/testdir/test_profile.vim
@@ -3,6 +3,8 @@ if !has('profile')
   finish
 endif
 
+source screendump.vim
+
 func Test_profile_func()
   let lines = [
     \ 'profile start Xprofile_func.log',
@@ -49,36 +51,260 @@ func Test_profile_func()
   " - Unlike Foo3(), Foo2() should not be deleted since there is a check
   "   for v:profiling.
   " - Bar() is not reported since it does not match "profile func Foo*".
-  call assert_equal(28, len(lines))
+  call assert_equal(30, len(lines))
+
+  call assert_equal('FUNCTION  Foo1()',                            lines[0])
+  call assert_match('Defined:.*Xprofile_func.vim',                 lines[1])
+  call assert_equal('Called 2 times',                              lines[2])
+  call assert_match('^Total time:\s\+\d\+\.\d\+$',                 lines[3])
+  call assert_match('^ Self time:\s\+\d\+\.\d\+$',                 lines[4])
+  call assert_equal('',                                            lines[5])
+  call assert_equal('count  total (s)   self (s)',                 lines[6])
+  call assert_equal('',                                            lines[7])
+  call assert_equal('FUNCTION  Foo2()',                            lines[8])
+  call assert_equal('Called 1 time',                               lines[10])
+  call assert_match('^Total time:\s\+\d\+\.\d\+$',                 lines[11])
+  call assert_match('^ Self time:\s\+\d\+\.\d\+$',                 lines[12])
+  call assert_equal('',                                            lines[13])
+  call assert_equal('count  total (s)   self (s)',                 lines[14])
+  call assert_match('^\s*1\s\+.*\slet l:count = 100$',             lines[15])
+  call assert_match('^\s*101\s\+.*\swhile l:count > 0$',           lines[16])
+  call assert_match('^\s*100\s\+.*\s  let l:count = l:count - 1$', lines[17])
+  call assert_match('^\s*101\s\+.*\sendwhile$',                    lines[18])
+  call assert_equal('',                                            lines[19])
+  call assert_equal('FUNCTIONS SORTED ON TOTAL TIME',              lines[20])
+  call assert_equal('count  total (s)   self (s)  function',       lines[21])
+  call assert_match('^\s*1\s\+\d\+\.\d\+\s\+Foo2()$',              lines[22])
+  call assert_match('^\s*2\s\+\d\+\.\d\+\s\+Foo1()$',              lines[23])
+  call assert_equal('',                                            lines[24])
+  call assert_equal('FUNCTIONS SORTED ON SELF TIME',               lines[25])
+  call assert_equal('count  total (s)   self (s)  function',       lines[26])
+  call assert_match('^\s*1\s\+\d\+\.\d\+\s\+Foo2()$',              lines[27])
+  call assert_match('^\s*2\s\+\d\+\.\d\+\s\+Foo1()$',              lines[28])
+  call assert_equal('',                                            lines[29])
+
+  call delete('Xprofile_func.vim')
+  call delete('Xprofile_func.log')
+endfunc
+
+func Test_profile_func_with_ifelse()
+  let lines = [
+    \ "func! Foo1()",
+    \ "  if 1",
+    \ "    let x = 0",
+    \ "  elseif 1",
+    \ "    let x = 1",
+    \ "  else",
+    \ "    let x = 2",
+    \ "  endif",
+    \ "endfunc",
+    \ "func! Foo2()",
+    \ "  if 0",
+    \ "    let x = 0",
+    \ "  elseif 1",
+    \ "    let x = 1",
+    \ "  else",
+    \ "    let x = 2",
+    \ "  endif",
+    \ "endfunc",
+    \ "func! Foo3()",
+    \ "  if 0",
+    \ "    let x = 0",
+    \ "  elseif 0",
+    \ "    let x = 1",
+    \ "  else",
+    \ "    let x = 2",
+    \ "  endif",
+    \ "endfunc",
+    \ "call Foo1()",
+    \ "call Foo2()",
+    \ "call Foo3()",
+    \ ]
+
+  call writefile(lines, 'Xprofile_func.vim')
+  call system(v:progpath
+    \ . ' -es -u NONE -U NONE -i NONE --noplugin'
+    \ . ' -c "profile start Xprofile_func.log"'
+    \ . ' -c "profile func Foo*"'
+    \ . ' -c "so Xprofile_func.vim"'
+    \ . ' -c "qall!"')
+  call assert_equal(0, v:shell_error)
+
+  let lines = readfile('Xprofile_func.log')
+
+  " - Foo1() should pass 'if' block.
+  " - Foo2() should pass 'elseif' block.
+  " - Foo3() should pass 'else' block.
+  call assert_equal(57, len(lines))
+
+  call assert_equal('FUNCTION  Foo1()',                            lines[0])
+  call assert_match('Defined:.*Xprofile_func.vim',                 lines[1])
+  call assert_equal('Called 1 time',                               lines[2])
+  call assert_match('^Total time:\s\+\d\+\.\d\+$',                 lines[3])
+  call assert_match('^ Self time:\s\+\d\+\.\d\+$',                 lines[4])
+  call assert_equal('',                                            lines[5])
+  call assert_equal('count  total (s)   self (s)',                 lines[6])
+  call assert_match('^\s*1\s\+.*\sif 1$',                          lines[7])
+  call assert_match('^\s*1\s\+.*\s  let x = 0$',                   lines[8])
+  call assert_match(        '^\s\+elseif 1$',                      lines[9])
+  call assert_match(          '^\s\+let x = 1$',                   lines[10])
+  call assert_match(        '^\s\+else$',                          lines[11])
+  call assert_match(          '^\s\+let x = 2$',                   lines[12])
+  call assert_match('^\s*1\s\+.*\sendif$',                         lines[13])
+  call assert_equal('',                                            lines[14])
+  call assert_equal('FUNCTION  Foo2()',                            lines[15])
+  call assert_equal('Called 1 time',                               lines[17])
+  call assert_match('^Total time:\s\+\d\+\.\d\+$',                 lines[18])
+  call assert_match('^ Self time:\s\+\d\+\.\d\+$',                 lines[19])
+  call assert_equal('',                                            lines[20])
+  call assert_equal('count  total (s)   self (s)',                 lines[21])
+  call assert_match('^\s*1\s\+.*\sif 0$',                          lines[22])
+  call assert_match(          '^\s\+let x = 0$',                   lines[23])
+  call assert_match('^\s*1\s\+.*\selseif 1$',                      lines[24])
+  call assert_match('^\s*1\s\+.*\s  let x = 1$',                   lines[25])
+  call assert_match(        '^\s\+else$',                          lines[26])
+  call assert_match(          '^\s\+let x = 2$',                   lines[27])
+  call assert_match('^\s*1\s\+.*\sendif$',                         lines[28])
+  call assert_equal('',                                            lines[29])
+  call assert_equal('FUNCTION  Foo3()',                            lines[30])
+  call assert_equal('Called 1 time',                               lines[32])
+  call assert_match('^Total time:\s\+\d\+\.\d\+$',                 lines[33])
+  call assert_match('^ Self time:\s\+\d\+\.\d\+$',                 lines[34])
+  call assert_equal('',                                            lines[35])
+  call assert_equal('count  total (s)   self (s)',                 lines[36])
+  call assert_match('^\s*1\s\+.*\sif 0$',                          lines[37])
+  call assert_match(          '^\s\+let x = 0$',                   lines[38])
+  call assert_match('^\s*1\s\+.*\selseif 0$',                      lines[39])
+  call assert_match(          '^\s\+let x = 1$',                   lines[40])
+  call assert_match('^\s*1\s\+.*\selse$',                          lines[41])
+  call assert_match('^\s*1\s\+.*\s  let x = 2$',                   lines[42])
+  call assert_match('^\s*1\s\+.*\sendif$',                         lines[43])
+  call assert_equal('',                                            lines[44])
+  call assert_equal('FUNCTIONS SORTED ON TOTAL TIME',              lines[45])
+  call assert_equal('count  total (s)   self (s)  function',       lines[46])
+  call assert_match('^\s*1\s\+\d\+\.\d\+\s\+Foo.()$',              lines[47])
+  call assert_match('^\s*1\s\+\d\+\.\d\+\s\+Foo.()$',              lines[48])
+  call assert_match('^\s*1\s\+\d\+\.\d\+\s\+Foo.()$',              lines[49])
+  call assert_equal('',                                            lines[50])
+  call assert_equal('FUNCTIONS SORTED ON SELF TIME',               lines[51])
+  call assert_equal('count  total (s)   self (s)  function',       lines[52])
+  call assert_match('^\s*1\s\+\d\+\.\d\+\s\+Foo.()$',              lines[53])
+  call assert_match('^\s*1\s\+\d\+\.\d\+\s\+Foo.()$',              lines[54])
+  call assert_match('^\s*1\s\+\d\+\.\d\+\s\+Foo.()$',              lines[55])
+  call assert_equal('',                                            lines[56])
+
+  call delete('Xprofile_func.vim')
+  call delete('Xprofile_func.log')
+endfunc
+
+func Test_profile_func_with_trycatch()
+  let lines = [
+    \ "func! Foo1()",
+    \ "  try",
+    \ "    let x = 0",
+    \ "  catch",
+    \ "    let x = 1",
+    \ "  finally",
+    \ "    let x = 2",
+    \ "  endtry",
+    \ "endfunc",
+    \ "func! Foo2()",
+    \ "  try",
+    \ "    throw 0",
+    \ "  catch",
+    \ "    let x = 1",
+    \ "  finally",
+    \ "    let x = 2",
+    \ "  endtry",
+    \ "endfunc",
+    \ "func! Foo3()",
+    \ "  try",
+    \ "    throw 0",
+    \ "  catch",
+    \ "    throw 1",
+    \ "  finally",
+    \ "    let x = 2",
+    \ "  endtry",
+    \ "endfunc",
+    \ "call Foo1()",
+    \ "call Foo2()",
+    \ "try",
+    \ "  call Foo3()",
+    \ "catch",
+    \ "endtry",
+    \ ]
+
+  call writefile(lines, 'Xprofile_func.vim')
+  call system(v:progpath
+    \ . ' -es -u NONE -U NONE -i NONE --noplugin'
+    \ . ' -c "profile start Xprofile_func.log"'
+    \ . ' -c "profile func Foo*"'
+    \ . ' -c "so Xprofile_func.vim"'
+    \ . ' -c "qall!"')
+  call assert_equal(0, v:shell_error)
+
+  let lines = readfile('Xprofile_func.log')
+
+  " - Foo1() should pass 'try' 'finally' blocks.
+  " - Foo2() should pass 'catch' 'finally' blocks.
+  " - Foo3() should not pass 'endtry'.
+  call assert_equal(57, len(lines))
 
   call assert_equal('FUNCTION  Foo1()',                            lines[0])
-  call assert_equal('Called 2 times',                              lines[1])
-  call assert_match('^Total time:\s\+\d\+\.\d\+$',                 lines[2])
-  call assert_match('^ Self time:\s\+\d\+\.\d\+$',                 lines[3])
-  call assert_equal('',                                            lines[4])
-  call assert_equal('count  total (s)   self (s)',                 lines[5])
-  call assert_equal('',                                            lines[6])
-  call assert_equal('FUNCTION  Foo2()',                            lines[7])
-  call assert_equal('Called 1 time',                               lines[8])
-  call assert_match('^Total time:\s\+\d\+\.\d\+$',                 lines[9])
-  call assert_match('^ Self time:\s\+\d\+\.\d\+$',                 lines[10])
-  call assert_equal('',                                            lines[11])
-  call assert_equal('count  total (s)   self (s)',                 lines[12])
-  call assert_match('^\s*1\s\+.*\slet l:count = 100$',             lines[13])
-  call assert_match('^\s*101\s\+.*\swhile l:count > 0$',           lines[14])
-  call assert_match('^\s*100\s\+.*\s  let l:count = l:count - 1$', lines[15])
-  call assert_match('^\s*100\s\+.*\sendwhile$',                    lines[16])
-  call assert_equal('',                                            lines[17])
-  call assert_equal('FUNCTIONS SORTED ON TOTAL TIME',              lines[18])
-  call assert_equal('count  total (s)   self (s)  function',       lines[19])
-  call assert_match('^\s*1\s\+\d\+\.\d\+\s\+Foo2()$',              lines[20])
-  call assert_match('^\s*2\s\+\d\+\.\d\+\s\+Foo1()$',              lines[21])
-  call assert_equal('',                                            lines[22])
-  call assert_equal('FUNCTIONS SORTED ON SELF TIME',               lines[23])
-  call assert_equal('count  total (s)   self (s)  function',       lines[24])
-  call assert_match('^\s*1\s\+\d\+\.\d\+\s\+Foo2()$',              lines[25])
-  call assert_match('^\s*2\s\+\d\+\.\d\+\s\+Foo1()$',              lines[26])
-  call assert_equal('',                                            lines[27])
+  call assert_match('Defined:.*Xprofile_func.vim',                 lines[1])
+  call assert_equal('Called 1 time',                               lines[2])
+  call assert_match('^Total time:\s\+\d\+\.\d\+$',                 lines[3])
+  call assert_match('^ Self time:\s\+\d\+\.\d\+$',                 lines[4])
+  call assert_equal('',                                            lines[5])
+  call assert_equal('count  total (s)   self (s)',                 lines[6])
+  call assert_match('^\s*1\s\+.*\stry$',                           lines[7])
+  call assert_match('^\s*1\s\+.*\s  let x = 0$',                   lines[8])
+  call assert_match(        '^\s\+catch$',                         lines[9])
+  call assert_match(          '^\s\+let x = 1$',                   lines[10])
+  call assert_match('^\s*1\s\+.*\sfinally$',                       lines[11])
+  call assert_match('^\s*1\s\+.*\s  let x = 2$',                   lines[12])
+  call assert_match('^\s*1\s\+.*\sendtry$',                        lines[13])
+  call assert_equal('',                                            lines[14])
+  call assert_equal('FUNCTION  Foo2()',                            lines[15])
+  call assert_equal('Called 1 time',                               lines[17])
+  call assert_match('^Total time:\s\+\d\+\.\d\+$',                 lines[18])
+  call assert_match('^ Self time:\s\+\d\+\.\d\+$',                 lines[19])
+  call assert_equal('',                                            lines[20])
+  call assert_equal('count  total (s)   self (s)',                 lines[21])
+  call assert_match('^\s*1\s\+.*\stry$',                           lines[22])
+  call assert_match('^\s*1\s\+.*\s  throw 0$',                     lines[23])
+  call assert_match('^\s*1\s\+.*\scatch$',                         lines[24])
+  call assert_match('^\s*1\s\+.*\s  let x = 1$',                   lines[25])
+  call assert_match('^\s*1\s\+.*\sfinally$',                       lines[26])
+  call assert_match('^\s*1\s\+.*\s  let x = 2$',                   lines[27])
+  call assert_match('^\s*1\s\+.*\sendtry$',                        lines[28])
+  call assert_equal('',                                            lines[29])
+  call assert_equal('FUNCTION  Foo3()',                            lines[30])
+  call assert_equal('Called 1 time',                               lines[32])
+  call assert_match('^Total time:\s\+\d\+\.\d\+$',                 lines[33])
+  call assert_match('^ Self time:\s\+\d\+\.\d\+$',                 lines[34])
+  call assert_equal('',                                            lines[35])
+  call assert_equal('count  total (s)   self (s)',                 lines[36])
+  call assert_match('^\s*1\s\+.*\stry$',                           lines[37])
+  call assert_match('^\s*1\s\+.*\s  throw 0$',                     lines[38])
+  call assert_match('^\s*1\s\+.*\scatch$',                         lines[39])
+  call assert_match('^\s*1\s\+.*\s  throw 1$',                     lines[40])
+  call assert_match('^\s*1\s\+.*\sfinally$',                       lines[41])
+  call assert_match('^\s*1\s\+.*\s  let x = 2$',                   lines[42])
+  call assert_match(        '^\s\+endtry$',                        lines[43])
+  call assert_equal('',                                            lines[44])
+  call assert_equal('FUNCTIONS SORTED ON TOTAL TIME',              lines[45])
+  call assert_equal('count  total (s)   self (s)  function',       lines[46])
+  call assert_match('^\s*1\s\+\d\+\.\d\+\s\+Foo.()$',              lines[47])
+  call assert_match('^\s*1\s\+\d\+\.\d\+\s\+Foo.()$',              lines[48])
+  call assert_match('^\s*1\s\+\d\+\.\d\+\s\+Foo.()$',              lines[49])
+  call assert_equal('',                                            lines[50])
+  call assert_equal('FUNCTIONS SORTED ON SELF TIME',               lines[51])
+  call assert_equal('count  total (s)   self (s)  function',       lines[52])
+  call assert_match('^\s*1\s\+\d\+\.\d\+\s\+Foo.()$',              lines[53])
+  call assert_match('^\s*1\s\+\d\+\.\d\+\s\+Foo.()$',              lines[54])
+  call assert_match('^\s*1\s\+\d\+\.\d\+\s\+Foo.()$',              lines[55])
+  call assert_equal('',                                            lines[56])
 
   call delete('Xprofile_func.vim')
   call delete('Xprofile_func.log')
@@ -123,7 +349,7 @@ func Test_profile_file()
   call assert_equal('                              " a comment',      lines[9])
   " if self and total are equal we only get one number
   call assert_match('^\s*20\s\+\(\d\+\.\d\+\s\+\)\=\d\+\.\d\+\s\+call Foo()$', lines[10])
-  call assert_match('^\s*20\s\+\d\+\.\d\+\s\+endfor$',                lines[11])
+  call assert_match('^\s*22\s\+\d\+\.\d\+\s\+endfor$',                lines[11])
   " if self and total are equal we only get one number
   call assert_match('^\s*2\s\+\(\d\+\.\d\+\s\+\)\=\d\+\.\d\+\s\+call Foo()$', lines[12])
   call assert_equal('',                                               lines[13])
@@ -249,18 +475,19 @@ func Test_profdel_func()
   call assert_equal(0, v:shell_error)
 
   let lines = readfile('Xprofile_file.log')
-  call assert_equal(24, len(lines))
+  call assert_equal(26, len(lines))
 
   " Check that:
   " - Foo1() is called twice (profdel not invoked)
   " - Foo2() is called once (profdel invoked after it was called)
   " - Foo3() is not called (profdel invoked before it was called)
   call assert_equal('FUNCTION  Foo1()',               lines[0])
-  call assert_equal('Called 2 times',                 lines[1])
-  call assert_equal('FUNCTION  Foo2()',               lines[7])
-  call assert_equal('Called 1 time',                  lines[8])
-  call assert_equal('FUNCTIONS SORTED ON TOTAL TIME', lines[14])
-  call assert_equal('FUNCTIONS SORTED ON SELF TIME',  lines[19])
+  call assert_match('Defined:.*Xprofile_file.vim',    lines[1])
+  call assert_equal('Called 2 times',                 lines[2])
+  call assert_equal('FUNCTION  Foo2()',               lines[8])
+  call assert_equal('Called 1 time',                  lines[10])
+  call assert_equal('FUNCTIONS SORTED ON TOTAL TIME', lines[16])
+  call assert_equal('FUNCTIONS SORTED ON SELF TIME',  lines[21])
 
   call delete('Xprofile_file.vim')
   call delete('Xprofile_file.log')
@@ -282,13 +509,42 @@ func Test_profdel_star()
   call assert_equal(0, v:shell_error)
 
   let lines = readfile('Xprofile_file.log')
-  call assert_equal(15, len(lines))
+  call assert_equal(16, len(lines))
 
   call assert_equal('FUNCTION  Foo()',                lines[0])
-  call assert_equal('Called 1 time',                  lines[1])
-  call assert_equal('FUNCTIONS SORTED ON TOTAL TIME', lines[7])
-  call assert_equal('FUNCTIONS SORTED ON SELF TIME',  lines[11])
+  call assert_match('Defined:.*Xprofile_file.vim',    lines[1])
+  call assert_equal('Called 1 time',                  lines[2])
+  call assert_equal('FUNCTIONS SORTED ON TOTAL TIME', lines[8])
+  call assert_equal('FUNCTIONS SORTED ON SELF TIME',  lines[12])
 
   call delete('Xprofile_file.vim')
   call delete('Xprofile_file.log')
 endfunc
+
+" When typing the function it won't have a script ID, test that this works.
+func Test_profile_typed_func()
+  if !CanRunVimInTerminal()
+    throw 'Skipped: cannot run Vim in a terminal window'
+  endif
+
+  let lines =<< trim END
+      profile start XprofileTypedFunc
+  END
+  call writefile(lines, 'XtestProfile')
+  let buf = RunVimInTerminal('-S XtestProfile', #{})
+
+  call term_sendkeys(buf, ":func DoSomething()\<CR>"
+	\ .. "echo 'hello'\<CR>"
+	\ .. "endfunc\<CR>")
+  call term_sendkeys(buf, ":profile func DoSomething\<CR>")
+  call term_sendkeys(buf, ":call DoSomething()\<CR>")
+  call term_wait(buf, 200)
+  call StopVimInTerminal(buf)
+  let lines = readfile('XprofileTypedFunc')
+  call assert_equal("FUNCTION  DoSomething()", lines[0])
+  call assert_equal("Called 1 time", lines[1])
+
+  " clean up
+  call delete('XprofileTypedFunc')
+  call delete('XtestProfile')
+endfunc