diff options
| author | Justin M. Keyes <justinkz@gmail.com> | 2023-12-05 12:52:06 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-12-05 12:52:06 -0800 |
| commit | 27501d3b6a8d577cf3f5ecc3fe9e219f477586b7 (patch) | |
| tree | 8622096da73218b6c05ab5559f3516272033b5c1 /src | |
| parent | ca4fe083e5b1a7c2e93cf77aa849fbec72757627 (diff) | |
| download | rneovim-27501d3b6a8d577cf3f5ecc3fe9e219f477586b7.tar.gz rneovim-27501d3b6a8d577cf3f5ecc3fe9e219f477586b7.tar.bz2 rneovim-27501d3b6a8d577cf3f5ecc3fe9e219f477586b7.zip | |
test: fileio_spec is unreliable/flaky #26404
Problem:
CI sometimes fails. Something is triggering an extra fsync().
FAILED test/functional/core/fileio_spec.lua @ 52: fileio fsync() codepaths #8304
test/functional/core/fileio_spec.lua:87: Expected objects to be the same.
Passed in:
(number) 3
Expected:
(number) 2
stack traceback:
test/functional/core/fileio_spec.lua:87: in function <test/functional/core/fileio_spec.lua:52>
Solution:
Relax the assertion to `fsync >= 2` instead of exactly 2.
(Note this is not a behavior change: the next assertion has always
checked `fsync == 4`, it's just that the intermediate 3rd fsync was
never explicitly asserted.)
Diffstat (limited to 'src')
| -rw-r--r-- | src/nvim/globals.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/nvim/globals.h b/src/nvim/globals.h index 1299aa12e5..19e5c5a4a6 100644 --- a/src/nvim/globals.h +++ b/src/nvim/globals.h @@ -672,7 +672,7 @@ EXTERN bool must_redraw_pum INIT( = false); // redraw pum. NB: must_redraw EXTERN bool need_highlight_changed INIT( = true); -EXTERN FILE *scriptout INIT( = NULL); ///< Stream to write script to. +EXTERN FILE *scriptout INIT( = NULL); ///< Write input to this file ("nvim -w"). // Note that even when handling SIGINT, volatile is not necessary because the // callback is not called directly from the signal handlers. |