diff options
| author | ZyX <kp-pav@yandex.ru> | 2017-05-20 04:19:57 +0300 |
|---|---|---|
| committer | ZyX <kp-pav@yandex.ru> | 2017-05-20 04:21:00 +0300 |
| commit | 7d895ee05329d520a5d26c3dc7ede10ab9a36d94 (patch) | |
| tree | 21a7c4360415856a56ce0805d4e87dda83852d28 /src | |
| parent | 40444e9186a7d3666930de4abfb4662e603d1f06 (diff) | |
| download | rneovim-7d895ee05329d520a5d26c3dc7ede10ab9a36d94.tar.gz rneovim-7d895ee05329d520a5d26c3dc7ede10ab9a36d94.tar.bz2 rneovim-7d895ee05329d520a5d26c3dc7ede10ab9a36d94.zip | |
memfile: Fix V547: always true condition
`blocksize` was checked against UINT_MAX after it was checked against
MAX_SWAP_PAGE_SIZE which makes it always pass the check. Better use
STATIC_ASSERT instead.
Diffstat (limited to 'src')
| -rw-r--r-- | src/nvim/memfile.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/nvim/memfile.c b/src/nvim/memfile.c index efaf1f94c5..1abc69727c 100644 --- a/src/nvim/memfile.c +++ b/src/nvim/memfile.c @@ -54,6 +54,7 @@ #include "nvim/memory.h" #include "nvim/os_unix.h" #include "nvim/path.h" +#include "nvim/assert.h" #include "nvim/os/os.h" #include "nvim/os/input.h" @@ -108,7 +109,8 @@ memfile_T *mf_open(char_u *fname, int flags) if (mfp->mf_fd >= 0 && os_fileinfo_fd(mfp->mf_fd, &file_info)) { uint64_t blocksize = os_fileinfo_blocksize(&file_info); if (blocksize >= MIN_SWAP_PAGE_SIZE && blocksize <= MAX_SWAP_PAGE_SIZE) { - assert(blocksize <= UINT_MAX); + STATIC_ASSERT(MAX_SWAP_PAGE_SIZE <= UINT_MAX, + "MAX_SWAP_PAGE_SIZE must fit into an unsigned"); mfp->mf_page_size = (unsigned)blocksize; } } |