aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorzeertzjq <zeertzjq@outlook.com>2025-03-27 08:54:32 +0800
committerGitHub <noreply@github.com>2025-03-27 08:54:32 +0800
commit8f40ffdb92b6ca25529b470e4a4e2bb7ddbb000a (patch)
tree6f487685c4e43e7419b0d8dc460507be674746e0 /src
parentce590e207720ec53a4592882840725bf8540c7d5 (diff)
parent797195e0ea554f2e546ced9104e8fbfa376f283f (diff)
downloadrneovim-8f40ffdb92b6ca25529b470e4a4e2bb7ddbb000a.tar.gz
rneovim-8f40ffdb92b6ca25529b470e4a4e2bb7ddbb000a.tar.bz2
rneovim-8f40ffdb92b6ca25529b470e4a4e2bb7ddbb000a.zip
Merge pull request #32953 from glepnir/vim-9.1.1214
vim-patch:9.1.{1214,1217,1219}: matchfuzzy() "camelcase"
Diffstat (limited to 'src')
-rw-r--r--src/nvim/eval.lua3
-rw-r--r--src/nvim/quickfix.c2
-rw-r--r--src/nvim/search.c38
3 files changed, 28 insertions, 15 deletions
diff --git a/src/nvim/eval.lua b/src/nvim/eval.lua
index 8ca1868ff1..ffdbacb2b4 100644
--- a/src/nvim/eval.lua
+++ b/src/nvim/eval.lua
@@ -7150,6 +7150,9 @@ M.funcs = {
given sequence.
limit Maximum number of matches in {list} to be
returned. Zero means no limit.
+ camelcase Use enhanced camel case scoring making results
+ better suited for completion related to
+ programming languages. Defaults to v:true.
If {list} is a list of dictionaries, then the optional {dict}
argument supports the following additional items:
diff --git a/src/nvim/quickfix.c b/src/nvim/quickfix.c
index 44b66c4f73..5f197bc84f 100644
--- a/src/nvim/quickfix.c
+++ b/src/nvim/quickfix.c
@@ -5356,7 +5356,7 @@ static bool vgr_match_buflines(qf_list_T *qfl, char *fname, buf_T *buf, char *sp
// Fuzzy string match
CLEAR_FIELD(matches);
- while (fuzzy_match(str + col, spat, false, &score, matches, (int)sz) > 0) {
+ while (fuzzy_match(str + col, spat, false, &score, matches, (int)sz, true) > 0) {
// Pass the buffer number so that it gets used even for a
// dummy buffer, unless duplicate_name is set, then the
// buffer will be wiped out below.
diff --git a/src/nvim/search.c b/src/nvim/search.c
index b38296ac5c..fe8e54fed4 100644
--- a/src/nvim/search.c
+++ b/src/nvim/search.c
@@ -2996,7 +2996,7 @@ typedef struct {
/// are in "matches".
static int fuzzy_match_compute_score(const char *const fuzpat, const char *const str,
const int strSz, const uint32_t *const matches,
- const int numMatches)
+ const int numMatches, bool camelcase)
FUNC_ATTR_NONNULL_ALL FUNC_ATTR_WARN_UNUSED_RESULT FUNC_ATTR_PURE
{
assert(numMatches > 0); // suppress clang "result of operation is garbage"
@@ -3055,7 +3055,7 @@ static int fuzzy_match_compute_score(const char *const fuzpat, const char *const
curr = utf_ptr2char(p);
// Enhanced camel case scoring
- if (mb_islower(neighbor) && mb_isupper(curr)) {
+ if (camelcase && mb_islower(neighbor) && mb_isupper(curr)) {
score += CAMEL_BONUS * 2; // Double the camel case bonus
is_camel = true;
consecutive_camel++;
@@ -3114,7 +3114,8 @@ static int fuzzy_match_compute_score(const char *const fuzpat, const char *const
static int fuzzy_match_recursive(const char *fuzpat, const char *str, uint32_t strIdx,
int *const outScore, const char *const strBegin, const int strLen,
const uint32_t *const srcMatches, uint32_t *const matches,
- const int maxMatches, int nextMatch, int *const recursionCount)
+ const int maxMatches, int nextMatch, int *const recursionCount,
+ bool camelcase)
FUNC_ATTR_NONNULL_ARG(1, 2, 4, 5, 8, 11) FUNC_ATTR_WARN_UNUSED_RESULT
{
// Recursion params
@@ -3161,7 +3162,7 @@ static int fuzzy_match_recursive(const char *fuzpat, const char *str, uint32_t s
if (fuzzy_match_recursive(fuzpat, next_char, strIdx + 1, &recursiveScore, strBegin, strLen,
matches, recursiveMatches,
sizeof(recursiveMatches) / sizeof(recursiveMatches[0]), nextMatch,
- recursionCount)) {
+ recursionCount, camelcase)) {
// Pick best recursive score
if (!recursiveMatch || recursiveScore > bestRecursiveScore) {
memcpy(bestRecursiveMatches, recursiveMatches,
@@ -3184,7 +3185,7 @@ static int fuzzy_match_recursive(const char *fuzpat, const char *str, uint32_t s
// Calculate score
if (matched) {
- *outScore = fuzzy_match_compute_score(fuzpat, strBegin, strLen, matches, nextMatch);
+ *outScore = fuzzy_match_compute_score(fuzpat, strBegin, strLen, matches, nextMatch, camelcase);
}
// Return best result
@@ -3213,7 +3214,7 @@ static int fuzzy_match_recursive(const char *fuzpat, const char *str, uint32_t s
/// @return true if "pat_arg" matches "str". Also returns the match score in
/// "outScore" and the matching character positions in "matches".
bool fuzzy_match(char *const str, const char *const pat_arg, const bool matchseq,
- int *const outScore, uint32_t *const matches, const int maxMatches)
+ int *const outScore, uint32_t *const matches, const int maxMatches, bool camelcase)
FUNC_ATTR_NONNULL_ALL
{
const int len = mb_charlen(str);
@@ -3251,7 +3252,7 @@ bool fuzzy_match(char *const str, const char *const pat_arg, const bool matchseq
const int matchCount
= fuzzy_match_recursive(pat, str, 0, &score, str, len, NULL,
matches + numMatches,
- maxMatches - numMatches, 0, &recursionCount);
+ maxMatches - numMatches, 0, &recursionCount, camelcase);
if (matchCount == 0) {
numMatches = 0;
break;
@@ -3301,7 +3302,7 @@ static int fuzzy_match_item_compare(const void *const s1, const void *const s2)
static void fuzzy_match_in_list(list_T *const l, char *const str, const bool matchseq,
const char *const key, Callback *const item_cb,
const bool retmatchpos, list_T *const fmatchlist,
- const int max_matches)
+ const int max_matches, bool camelcase)
FUNC_ATTR_NONNULL_ARG(2, 5, 7)
{
int len = tv_list_len(l);
@@ -3352,7 +3353,7 @@ static void fuzzy_match_in_list(list_T *const l, char *const str, const bool mat
int score;
if (itemstr != NULL && fuzzy_match(itemstr, str, matchseq, &score, matches,
- MAX_FUZZY_MATCHES)) {
+ MAX_FUZZY_MATCHES, camelcase)) {
items[match_count].idx = (int)match_count;
items[match_count].item = li;
items[match_count].score = score;
@@ -3452,6 +3453,7 @@ static void do_fuzzymatch(const typval_T *const argvars, typval_T *const rettv,
const char *key = NULL;
bool matchseq = false;
int max_matches = 0;
+ bool camelcase = true;
if (argvars[2].v_type != VAR_UNKNOWN) {
if (tv_check_for_nonnull_dict_arg(argvars, 2) == FAIL) {
return;
@@ -3464,7 +3466,7 @@ static void do_fuzzymatch(const typval_T *const argvars, typval_T *const rettv,
if ((di = tv_dict_find(d, "key", -1)) != NULL) {
if (di->di_tv.v_type != VAR_STRING || di->di_tv.vval.v_string == NULL
|| *di->di_tv.vval.v_string == NUL) {
- semsg(_(e_invarg2), tv_get_string(&di->di_tv));
+ semsg(_(e_invargNval), "key", tv_get_string(&di->di_tv));
return;
}
key = tv_get_string(&di->di_tv);
@@ -3475,12 +3477,20 @@ static void do_fuzzymatch(const typval_T *const argvars, typval_T *const rettv,
if ((di = tv_dict_find(d, "limit", -1)) != NULL) {
if (di->di_tv.v_type != VAR_NUMBER) {
- semsg(_(e_invarg2), tv_get_string(&di->di_tv));
+ semsg(_(e_invargval), "limit");
return;
}
max_matches = (int)tv_get_number_chk(&di->di_tv, NULL);
}
+ if ((di = tv_dict_find(d, "camelcase", -1)) != NULL) {
+ if (di->di_tv.v_type != VAR_BOOL) {
+ semsg(_(e_invargval), "camelcase");
+ return;
+ }
+ camelcase = tv_get_bool_chk(&di->di_tv, NULL);
+ }
+
if (tv_dict_find(d, "matchseq", -1) != NULL) {
matchseq = true;
}
@@ -3500,7 +3510,7 @@ static void do_fuzzymatch(const typval_T *const argvars, typval_T *const rettv,
fuzzy_match_in_list(argvars[0].vval.v_list,
(char *)tv_get_string(&argvars[1]), matchseq, key,
- &cb, retmatchpos, rettv->vval.v_list, max_matches);
+ &cb, retmatchpos, rettv->vval.v_list, max_matches, camelcase);
callback_free(&cb);
}
@@ -3584,7 +3594,7 @@ int fuzzy_match_str(char *const str, const char *const pat)
int score = 0;
uint32_t matchpos[MAX_FUZZY_MATCHES];
- fuzzy_match(str, pat, true, &score, matchpos, sizeof(matchpos) / sizeof(matchpos[0]));
+ fuzzy_match(str, pat, true, &score, matchpos, sizeof(matchpos) / sizeof(matchpos[0]), true);
return score;
}
@@ -3602,7 +3612,7 @@ garray_T *fuzzy_match_str_with_pos(char *const str, const char *const pat)
unsigned matches[MAX_FUZZY_MATCHES];
int score = 0;
- if (!fuzzy_match(str, pat, false, &score, matches, MAX_FUZZY_MATCHES)
+ if (!fuzzy_match(str, pat, false, &score, matches, MAX_FUZZY_MATCHES, true)
|| score == 0) {
ga_clear(match_positions);
xfree(match_positions);