diff options
author | Daniel Hahler <git@thequod.de> | 2019-07-04 02:37:29 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-07-04 02:37:29 +0200 |
commit | 99b870d61c0a574011d16886d2cea44d18c11a2d (patch) | |
tree | 4f5db6d9d6a71f346d6bd34ff0083c29f5683ed8 /src | |
parent | f6298aba82f5378f5c53ab746c3f976b645d0a98 (diff) | |
download | rneovim-99b870d61c0a574011d16886d2cea44d18c11a2d.tar.gz rneovim-99b870d61c0a574011d16886d2cea44d18c11a2d.tar.bz2 rneovim-99b870d61c0a574011d16886d2cea44d18c11a2d.zip |
build: bundle: clean binary dir with new downloads (#10411)
This is required to (re)build e.g. libluv when the version changes
(which triggers a new download).
With `make deps`, changing the `LUV_URL`/`LUV_SHA256`, and `make deps` again:
Before:
> Up-to-date: /home/daniel/Vcs/neovim/.deps/usr/lib/libluv.a
After:
> Installing: /home/daniel/Vcs/neovim/.deps/usr/lib/libluv.a
See with https://github.com/neovim/neovim/pull/10358 - where .deps
contained libluv 1.29, the merge updates it to 1.30, but then it failed
to link because `libluv.a` is considered to be up-to-date (after
downloading the new version).
Note that header files get installed, since they have the original time
stamp, but `libluv.a` is being generated (does not use the timestamp
from the archive here, but needs to get rebuild).
It could be argued that the build system of the included project should
catch/handle this, but it seems to be good practice to clean the binary
/ build dir with a new download to start from scratch.
Ref: https://gitlab.kitware.com/cmake/cmake/issues/19452
Also fixes cmake/BuildLuv / luv-static: use name with -DTARGET for
download command, and pass (shared) `SRC_DIR` explicitly instead.
Diffstat (limited to 'src')
0 files changed, 0 insertions, 0 deletions