aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorSean Dewar <seandewar@users.noreply.github.com>2021-05-22 20:21:44 +0100
committerSean Dewar <seandewar@users.noreply.github.com>2021-09-11 15:33:20 +0100
commitb6d9e92805b4cf37680be61c1c22ddf7a061d649 (patch)
tree8bcc94d8bc359470a6d08f82fa07171745d13cb0 /src
parent6617629ad6eceeb77d49633780a7213eeb17a2c9 (diff)
downloadrneovim-b6d9e92805b4cf37680be61c1c22ddf7a061d649.tar.gz
rneovim-b6d9e92805b4cf37680be61c1c22ddf7a061d649.tar.bz2
rneovim-b6d9e92805b4cf37680be61c1c22ddf7a061d649.zip
vim-patch:8.1.2036: the str2nr() tests fail
Problem: The str2nr() tests fail. Solution: Add missing part of patch. https://github.com/vim/vim/commit/1ac90b4fa63414d56750559506a3e076df6923b0 Add extra tests for quoted numbers in vim_str2nr_spec.lua, as the included ones in this patch are somewhat lacking.
Diffstat (limited to 'src')
-rw-r--r--src/nvim/charset.c16
1 files changed, 14 insertions, 2 deletions
diff --git a/src/nvim/charset.c b/src/nvim/charset.c
index 9f11e85b01..7b08488925 100644
--- a/src/nvim/charset.c
+++ b/src/nvim/charset.c
@@ -1396,6 +1396,7 @@ bool vim_isblankline(char_u *lbuf)
/// If "what" contains STR2NR_OCT recognize octal numbers.
/// If "what" contains STR2NR_HEX recognize hex numbers.
/// If "what" contains STR2NR_FORCE always assume bin/oct/hex.
+/// If "what" contains STR2NR_QUOTE ignore embedded single quotes
/// If maxlen > 0, check at a maximum maxlen chars.
/// If strict is true, check the number strictly. return *len = 0 if fail.
///
@@ -1434,7 +1435,7 @@ void vim_str2nr(const char_u *const start, int *const prep, int *const len,
if (what & STR2NR_FORCE) {
// When forcing main consideration is skipping the prefix. Octal and decimal
// numbers have no prefixes to skip. pre is not set.
- switch ((unsigned)what & (~(unsigned)STR2NR_FORCE)) {
+ switch (what & ~(STR2NR_FORCE | STR2NR_QUOTE)) {
case STR2NR_HEX: {
if (!STRING_ENDED(ptr + 2)
&& ptr[0] == '0'
@@ -1504,7 +1505,18 @@ void vim_str2nr(const char_u *const start, int *const prep, int *const len,
abort(); // Should’ve used goto earlier.
#define PARSE_NUMBER(base, cond, conv) \
do { \
- while (!STRING_ENDED(ptr) && (cond)) { \
+ const char *const after_prefix = ptr; \
+ while (!STRING_ENDED(ptr)) { \
+ if ((what & STR2NR_QUOTE) && ptr > after_prefix && *ptr == '\'') { \
+ ptr++; \
+ if (!STRING_ENDED(ptr) && (cond)) { \
+ continue; \
+ } \
+ ptr--; \
+ } \
+ if (!(cond)) { \
+ break; \
+ } \
const uvarnumber_T digit = (uvarnumber_T)(conv); \
/* avoid ubsan error for overflow */ \
if (un < UVARNUMBER_MAX / base \