diff options
author | glepnir <glephunter@gmail.com> | 2025-01-05 21:57:53 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-01-05 05:57:53 -0800 |
commit | bf48dfadeccc37527e9b59b1c0f529ea889bf735 (patch) | |
tree | 981e84c2061924b40dd4690f079ddbe2e90be964 /src | |
parent | d288f7003d256f0f4f85254974239c5f47003ede (diff) | |
download | rneovim-bf48dfadeccc37527e9b59b1c0f529ea889bf735.tar.gz rneovim-bf48dfadeccc37527e9b59b1c0f529ea889bf735.tar.bz2 rneovim-bf48dfadeccc37527e9b59b1c0f529ea889bf735.zip |
fix(api): nvim__complete_set requires completeopt=popup #31177
Problem:
If completeopt does not include "popup" flag, nvim__complete_set still
auto-creates a floating preview window.
Solution:
Fail if completeopt does not include the "popup" flag.
Diffstat (limited to 'src')
-rw-r--r-- | src/nvim/api/vim.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/nvim/api/vim.c b/src/nvim/api/vim.c index 25f44bb4eb..e3e69f4ff6 100644 --- a/src/nvim/api/vim.c +++ b/src/nvim/api/vim.c @@ -44,6 +44,7 @@ #include "nvim/highlight.h" #include "nvim/highlight_defs.h" #include "nvim/highlight_group.h" +#include "nvim/insexpand.h" #include "nvim/keycodes.h" #include "nvim/log.h" #include "nvim/lua/executor.h" @@ -2255,9 +2256,13 @@ void nvim_error_event(uint64_t channel_id, Integer lvl, String data) /// @return Dict containing these keys: /// - winid: (number) floating window id /// - bufnr: (number) buffer id in floating window -Dict nvim__complete_set(Integer index, Dict(complete_set) *opts, Arena *arena) +Dict nvim__complete_set(Integer index, Dict(complete_set) *opts, Arena *arena, Error *err) { Dict rv = arena_dict(arena, 2); + if ((get_cot_flags() & kOptCotFlagPopup) == 0) { + api_set_error(err, kErrorTypeException, "completeopt option does not include popup"); + return rv; + } if (HAS_KEY(opts, complete_set, info)) { win_T *wp = pum_set_info((int)index, opts->info.data); if (wp) { |