aboutsummaryrefslogtreecommitdiff
path: root/test/functional/api/vim_spec.lua
diff options
context:
space:
mode:
authorJustin M. Keyes <justinkz@gmail.com>2018-06-01 20:17:24 +0200
committerJustin M. Keyes <justinkz@gmail.com>2018-06-06 00:58:57 +0200
commit21c9db1861825cdc7f89e90bf166115a2581b663 (patch)
treef02ffcd7c1aeec8875a57710c9e9b3a59ea0f03a /test/functional/api/vim_spec.lua
parent5861dc596687b48e5817f944cdcffca50592fb38 (diff)
downloadrneovim-21c9db1861825cdc7f89e90bf166115a2581b663.tar.gz
rneovim-21c9db1861825cdc7f89e90bf166115a2581b663.tar.bz2
rneovim-21c9db1861825cdc7f89e90bf166115a2581b663.zip
build/CMake: find_package(… REQUIRED)
"Always use `find_package` with `REQUIRED`." - We make an exception for LuaJit (not REQUIRED): the `nvim-test` target is included only if we can find LuaJit. This is partially a cargo-cult (reference below), but it uncovered at least one problem: `find_package(LibIntl REQUIRED)` fails on my vanilla ubuntu 16.04 system. ref: https://schneide.blog/2017/11/06/4-tips-for-better-cmake/ > optional dependencies is nice, but skipping on REQUIRED is not the way > you want to do it. In the worst case, some of your features will just > not work if those packages are not found, with no explanation > whatsoever. Instead, use explicit feature-toggles (e.g. using option()) > that either skip the find_package call or use it with REQUIRED, so the > user will know that another lib is needed for this feature.
Diffstat (limited to 'test/functional/api/vim_spec.lua')
0 files changed, 0 insertions, 0 deletions