diff options
author | Justin M. Keyes <justinkz@gmail.com> | 2023-12-06 07:11:36 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-12-06 07:11:36 -0800 |
commit | c84af395e88ba143c19f7e34674bd222622e08ee (patch) | |
tree | 6a025727a2552854fe893e782ae8bc2adb5a81bd /test/functional/helpers.lua | |
parent | f64e4b43e1191ff30d902730f752875aa55682ce (diff) | |
download | rneovim-c84af395e88ba143c19f7e34674bd222622e08ee.tar.gz rneovim-c84af395e88ba143c19f7e34674bd222622e08ee.tar.bz2 rneovim-c84af395e88ba143c19f7e34674bd222622e08ee.zip |
test: 'nofsync' with deadly signal #26415
Problem:
The test for 'nofsync' swapfile preservation on a deadly signal, does
not actually assert anything.
followup to 1fd29a28841dee3d25ff079eb24fc160eb02cb3c
Solution:
Check that swapfile contents are present after getting SIGTERM.
TODO: this doesn't really verify that 'fsync' was called; it still
passes with this patch:
diff --git a/src/nvim/main.c b/src/nvim/main.c
index 216e39f3e81c..7a635520401d 100644
--- a/src/nvim/main.c
+++ b/src/nvim/main.c
@@ -838,7 +838,7 @@ void preserve_exit(const char *errmsg)
if (errmsg != NULL) {
os_errmsg("Vim: preserving files...\r\n");
}
- ml_sync_all(false, false, true); // preserve all swap files
+ ml_sync_all(false, false, false); // preserve all swap files
break;
}
}
However it correctly fails with this patch, at least:
diff --git a/src/nvim/main.c b/src/nvim/main.c
index 216e39f3e81c..f2306c310ddc 100644
--- a/src/nvim/main.c
+++ b/src/nvim/main.c
@@ -838,7 +838,6 @@ void preserve_exit(const char *errmsg)
if (errmsg != NULL) {
os_errmsg("Vim: preserving files...\r\n");
}
- ml_sync_all(false, false, true); // preserve all swap files
break;
}
}
Diffstat (limited to 'test/functional/helpers.lua')
-rw-r--r-- | test/functional/helpers.lua | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/test/functional/helpers.lua b/test/functional/helpers.lua index 2bff1d16f8..b50df4c677 100644 --- a/test/functional/helpers.lua +++ b/test/functional/helpers.lua @@ -438,7 +438,7 @@ function module.connect(file_or_address) return Session.new(stream) end --- Starts a new global Nvim session. +-- Starts (and returns) a new global Nvim session. -- -- Parameters are interpreted as startup args, OR a map with these keys: -- args: List: Args appended to the default `nvim_argv` set. @@ -452,6 +452,7 @@ end -- clear{args={'-e'}, args_rm={'-i'}, env={TERM=term}} function module.clear(...) module.set_session(module.spawn_argv(false, ...)) + return module.get_session() end -- same params as clear, but does returns the session instead @@ -943,7 +944,7 @@ function module.add_builddir_to_rtp() module.command(string.format([[set rtp+=%s/runtime]], module.test_build_dir)) end --- Kill process with given pid +-- Kill (reap) a process by PID. function module.os_kill(pid) return os.execute((is_os('win') and 'taskkill /f /t /pid '..pid..' > nul' |