fix(tests): needing two calls to setup a screen is cringe

Before calling "attach" a screen object is just a dummy container for
(row, col) values whose purpose is to be sent as part of the "attach"
function call anyway.

Just create the screen in an attached state directly. Keep the complete
(row, col, options) config together. It is still completely valid to
later detach and re-attach as needed, including to another session.

1 files changed, 0 insertions, 4 deletions

diff --git a/test/functional/legacy/number_spec.lua b/test/functional/legacy/number_spec.lua
index 0ebd731f65..4636cd0369 100644
--- a/test/functional/legacy/number_spec.lua
+++ b/test/functional/legacy/number_spec.lua
@@ -17,7 +17,6 @@ describe("'number' and 'relativenumber'", function()
       [2] = { foreground = Screen.colors.Blue },
       [3] = { foreground = Screen.colors.Green },
     })
-    screen:attach()
     exec([[
       call setline(1, range(200))
       111
@@ -86,7 +85,6 @@ describe("'number' and 'relativenumber'", function()
       [3] = { background = Screen.colors.Green, foreground = Screen.colors.Black },
       [4] = { bold = true, foreground = Screen.colors.Blue },
     })
-    screen:attach()
     exec([[
       set display=lastline scrolloff=0
       call setline(1, range(200)->map('v:val->string()->repeat(40)'))
@@ -215,7 +213,6 @@ describe("'number' and 'relativenumber'", function()
   -- oldtest: Test_relativenumber_callback()
   it('relative line numbers are updated if cursor is moved from timer', function()
     local screen = Screen.new(50, 8)
-    screen:attach()
     exec([[
       call setline(1, ['aaaaa', 'bbbbb', 'ccccc', 'ddddd'])
       set relativenumber
@@ -253,7 +250,6 @@ describe("'number' and 'relativenumber'", function()
   -- oldtest: Test_number_insert_delete_lines()
   it('line numbers are updated when deleting/inserting lines', function()
     local screen = Screen.new(50, 8)
-    screen:attach()
     exec([[
       call setline(1, range(1, 7))
       set number