fix(tests): needing two calls to setup a screen is cringe

Before calling "attach" a screen object is just a dummy container for
(row, col) values whose purpose is to be sent as part of the "attach"
function call anyway.

Just create the screen in an attached state directly. Keep the complete
(row, col, options) config together. It is still completely valid to
later detach and re-attach as needed, including to another session.

1 files changed, 2 insertions, 4 deletions

diff --git a/test/functional/terminal/ex_terminal_spec.lua b/test/functional/terminal/ex_terminal_spec.lua
index 1039572210..5ebe7bd4fc 100644
--- a/test/functional/terminal/ex_terminal_spec.lua
+++ b/test/functional/terminal/ex_terminal_spec.lua
@@ -21,8 +21,7 @@ describe(':terminal', function()
 
   before_each(function()
     clear()
-    screen = Screen.new(50, 4)
-    screen:attach({ rgb = false })
+    screen = Screen.new(50, 4, { rgb = false })
     screen._default_attr_ids = nil
   end)
 
@@ -169,8 +168,7 @@ local function test_terminal_with_fake_shell(backslash)
 
   before_each(function()
     clear()
-    screen = Screen.new(50, 4)
-    screen:attach({ rgb = false })
+    screen = Screen.new(50, 4, { rgb = false })
     screen._default_attr_ids = nil
     api.nvim_set_option_value('shell', shell_path, {})
     api.nvim_set_option_value('shellcmdflag', 'EXE', {})