diff options
| author | Björn Linse <bjorn.linse@gmail.com> | 2019-10-13 20:18:22 +0200 |
|---|---|---|
| committer | Björn Linse <bjorn.linse@gmail.com> | 2019-10-13 22:10:42 +0200 |
| commit | 4987311fb5b8f4a11d26995f71f5f402a9e2ace4 (patch) | |
| tree | e070d02687ba338260a004be738e777b1639e508 /test/functional/ui/cmdline_spec.lua | |
| parent | a330129a280a34963e42d498f7cb1f53e6723e85 (diff) | |
| download | rneovim-4987311fb5b8f4a11d26995f71f5f402a9e2ace4.tar.gz rneovim-4987311fb5b8f4a11d26995f71f5f402a9e2ace4.tar.bz2 rneovim-4987311fb5b8f4a11d26995f71f5f402a9e2ace4.zip | |
tests/ui: remove unnecessary screen:detach()
It is perfectly fine and expected to detach from the screen just by
the UI disconnecting from nvim or exiting nvim. Just keep detach() in
screen_basic_spec, to get some coverage of the detach method itself.
This avoids hang on failure in many situations (though one could argue
that detach() should be "fast", or at least "as fast as resize",
which works in press-return already).
Never use detach() just to change the size of the screen, try_resize()
method exists for that specifically.
Diffstat (limited to 'test/functional/ui/cmdline_spec.lua')
| -rw-r--r-- | test/functional/ui/cmdline_spec.lua | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/test/functional/ui/cmdline_spec.lua b/test/functional/ui/cmdline_spec.lua index f9769c706f..fe1b2c13d1 100644 --- a/test/functional/ui/cmdline_spec.lua +++ b/test/functional/ui/cmdline_spec.lua @@ -25,10 +25,6 @@ local function test_cmdline(linegrid) screen = new_screen({rgb=true, ext_cmdline=true, ext_linegrid=linegrid}) end) - after_each(function() - screen:detach() - end) - it('works', function() feed(':') screen:expect{grid=[[ @@ -804,10 +800,6 @@ describe('cmdline redraw', function() screen = new_screen({rgb=true}) end) - after_each(function() - screen:detach() - end) - it('with timer', function() feed(':012345678901234567890123456789') screen:expect{grid=[[ |