fix(tests): needing two calls to setup a screen is cringe

Before calling "attach" a screen object is just a dummy container for
(row, col) values whose purpose is to be sent as part of the "attach"
function call anyway.

Just create the screen in an attached state directly. Keep the complete
(row, col, options) config together. It is still completely valid to
later detach and re-attach as needed, including to another session.

1 files changed, 1 insertions, 6 deletions

diff --git a/test/functional/ui/hlstate_spec.lua b/test/functional/ui/hlstate_spec.lua
index 9873ab3103..f8f5ee9488 100644
--- a/test/functional/ui/hlstate_spec.lua
+++ b/test/functional/ui/hlstate_spec.lua
@@ -17,12 +17,7 @@ describe('ext_hlstate detailed highlights', function()
     clear()
     command('syntax on')
     command('hi VertSplit gui=reverse')
-    screen = Screen.new(40, 8)
-    screen:attach({ ext_hlstate = true })
-  end)
-
-  after_each(function()
-    screen:detach()
+    screen = Screen.new(40, 8, { ext_hlstate = true })
   end)
 
   it('work with combined UI and syntax highlights', function()