aboutsummaryrefslogtreecommitdiff
path: root/test/helpers.lua
diff options
context:
space:
mode:
authorJustin M. Keyes <justinkz@gmail.com>2023-12-05 12:52:06 -0800
committerGitHub <noreply@github.com>2023-12-05 12:52:06 -0800
commit27501d3b6a8d577cf3f5ecc3fe9e219f477586b7 (patch)
tree8622096da73218b6c05ab5559f3516272033b5c1 /test/helpers.lua
parentca4fe083e5b1a7c2e93cf77aa849fbec72757627 (diff)
downloadrneovim-27501d3b6a8d577cf3f5ecc3fe9e219f477586b7.tar.gz
rneovim-27501d3b6a8d577cf3f5ecc3fe9e219f477586b7.tar.bz2
rneovim-27501d3b6a8d577cf3f5ecc3fe9e219f477586b7.zip
test: fileio_spec is unreliable/flaky #26404
Problem: CI sometimes fails. Something is triggering an extra fsync(). FAILED test/functional/core/fileio_spec.lua @ 52: fileio fsync() codepaths #8304 test/functional/core/fileio_spec.lua:87: Expected objects to be the same. Passed in: (number) 3 Expected: (number) 2 stack traceback: test/functional/core/fileio_spec.lua:87: in function <test/functional/core/fileio_spec.lua:52> Solution: Relax the assertion to `fsync >= 2` instead of exactly 2. (Note this is not a behavior change: the next assertion has always checked `fsync == 4`, it's just that the intermediate 3rd fsync was never explicitly asserted.)
Diffstat (limited to 'test/helpers.lua')
-rw-r--r--test/helpers.lua6
1 files changed, 3 insertions, 3 deletions
diff --git a/test/helpers.lua b/test/helpers.lua
index d4ea8b27a3..4db2175a63 100644
--- a/test/helpers.lua
+++ b/test/helpers.lua
@@ -149,9 +149,9 @@ end
--- Retries for 1 second in case of filesystem delay.
---
---@param pat (string) Lua pattern to match lines in the log file
----@param logfile (string) Full path to log file (default=$NVIM_LOG_FILE)
----@param nrlines (number) Search up to this many log lines
----@param inverse (boolean) Assert that the pattern does NOT match.
+---@param logfile? (string) Full path to log file (default=$NVIM_LOG_FILE)
+---@param nrlines? (number) Search up to this many log lines
+---@param inverse? (boolean) Assert that the pattern does NOT match.
function module.assert_log(pat, logfile, nrlines, inverse)
logfile = logfile or os.getenv('NVIM_LOG_FILE') or '.nvimlog'
assert(logfile ~= nil, 'no logfile')