refactor(shada): rework msgpack decoding without msgpack-c

This also makes shada reading slightly faster due to avoiding
some copying and allocation.

Use keysets to drive decoding of msgpack maps for shada entries.

1 files changed, 18 insertions, 18 deletions

diff --git a/test/unit/eval/encode_spec.lua b/test/unit/eval/encode_spec.lua
index 5b9188163e..9f193bc2f9 100644
--- a/test/unit/eval/encode_spec.lua
+++ b/test/unit/eval/encode_spec.lua
@@ -21,81 +21,81 @@ describe('encode_list_write()', function()
 
   itp('writes empty string', function()
     local l = list()
-    eq(0, encode_list_write(l, ''))
+    encode_list_write(l, '')
     eq({ [type_key] = list_type }, lst2tbl(l))
   end)
 
   itp('writes ASCII string literal with printable characters', function()
     local l = list()
-    eq(0, encode_list_write(l, 'abc'))
+    encode_list_write(l, 'abc')
     eq({ 'abc' }, lst2tbl(l))
   end)
 
   itp('writes string starting with NL', function()
     local l = list()
-    eq(0, encode_list_write(l, '\nabc'))
+    encode_list_write(l, '\nabc')
     eq({ null_string, 'abc' }, lst2tbl(l))
   end)
 
   itp('writes string starting with NL twice', function()
     local l = list()
-    eq(0, encode_list_write(l, '\nabc'))
+    encode_list_write(l, '\nabc')
     eq({ null_string, 'abc' }, lst2tbl(l))
-    eq(0, encode_list_write(l, '\nabc'))
+    encode_list_write(l, '\nabc')
     eq({ null_string, 'abc', 'abc' }, lst2tbl(l))
   end)
 
   itp('writes string ending with NL', function()
     local l = list()
-    eq(0, encode_list_write(l, 'abc\n'))
+    encode_list_write(l, 'abc\n')
     eq({ 'abc', null_string }, lst2tbl(l))
   end)
 
   itp('writes string ending with NL twice', function()
     local l = list()
-    eq(0, encode_list_write(l, 'abc\n'))
+    encode_list_write(l, 'abc\n')
     eq({ 'abc', null_string }, lst2tbl(l))
-    eq(0, encode_list_write(l, 'abc\n'))
+    encode_list_write(l, 'abc\n')
     eq({ 'abc', 'abc', null_string }, lst2tbl(l))
   end)
 
   itp('writes string starting, ending and containing NL twice', function()
     local l = list()
-    eq(0, encode_list_write(l, '\na\nb\n'))
+    encode_list_write(l, '\na\nb\n')
     eq({ null_string, 'a', 'b', null_string }, lst2tbl(l))
-    eq(0, encode_list_write(l, '\na\nb\n'))
+    encode_list_write(l, '\na\nb\n')
     eq({ null_string, 'a', 'b', null_string, 'a', 'b', null_string }, lst2tbl(l))
   end)
 
   itp('writes string starting, ending and containing NUL with NL between twice', function()
     local l = list()
-    eq(0, encode_list_write(l, '\0\n\0\n\0'))
+    encode_list_write(l, '\0\n\0\n\0')
     eq({ '\n', '\n', '\n' }, lst2tbl(l))
-    eq(0, encode_list_write(l, '\0\n\0\n\0'))
+    encode_list_write(l, '\0\n\0\n\0')
     eq({ '\n', '\n', '\n\n', '\n', '\n' }, lst2tbl(l))
   end)
 
   itp('writes string starting, ending and containing NL with NUL between twice', function()
     local l = list()
-    eq(0, encode_list_write(l, '\n\0\n\0\n'))
+    encode_list_write(l, '\n\0\n\0\n')
     eq({ null_string, '\n', '\n', null_string }, lst2tbl(l))
-    eq(0, encode_list_write(l, '\n\0\n\0\n'))
+    encode_list_write(l, '\n\0\n\0\n')
     eq({ null_string, '\n', '\n', null_string, '\n', '\n', null_string }, lst2tbl(l))
   end)
 
   itp('writes string containing a single NL twice', function()
     local l = list()
-    eq(0, encode_list_write(l, '\n'))
+    encode_list_write(l, '\n')
     eq({ null_string, null_string }, lst2tbl(l))
-    eq(0, encode_list_write(l, '\n'))
+    encode_list_write(l, '\n')
     eq({ null_string, null_string, null_string }, lst2tbl(l))
   end)
 
   itp('writes string containing a few NLs twice', function()
     local l = list()
-    eq(0, encode_list_write(l, '\n\n\n'))
+    encode_list_write(l, '\n\n\n')
     eq({ null_string, null_string, null_string, null_string }, lst2tbl(l))
-    eq(0, encode_list_write(l, '\n\n\n'))
+    encode_list_write(l, '\n\n\n')
     eq(
       { null_string, null_string, null_string, null_string, null_string, null_string, null_string },
       lst2tbl(l)