diff options
| author | zeertzjq <zeertzjq@outlook.com> | 2023-12-02 10:17:43 +0800 |
|---|---|---|
| committer | zeertzjq <zeertzjq@outlook.com> | 2023-12-02 10:41:31 +0800 |
| commit | 9d7544ac4cd553c9b7c8b41926b7292c5ee85943 (patch) | |
| tree | 492b01ed1fed314cf279bb84857db1527be91d19 /test | |
| parent | 9cc346119bee505e0be3827b35c573701a307001 (diff) | |
| download | rneovim-9d7544ac4cd553c9b7c8b41926b7292c5ee85943.tar.gz rneovim-9d7544ac4cd553c9b7c8b41926b7292c5ee85943.tar.bz2 rneovim-9d7544ac4cd553c9b7c8b41926b7292c5ee85943.zip | |
vim-patch:9.0.2143: [security]: buffer-overflow in ex_substitute
Problem: [security]: buffer-overflow in ex_substitute
Solution: clear memory after allocating
When allocating the new_start pointer in ex_substitute() the memory
pointer points to some garbage that the following for loop in
ex_cmds.c:4743 confuses and causes it to accessing the new_start pointer
beyond it's size, leading to a buffer-overlow.
So fix this by using alloc_clear() instead of alloc(), which will
clear the memory by NUL and therefore cause the loop to terminate
correctly.
Reported by @henices, thanks!
closes: vim/vim#13596
https://github.com/vim/vim/commit/abfa13ebe92d81aaf66669c428d767847b577453
Co-authored-by: Christian Brabandt <cb@256bit.org>
Diffstat (limited to 'test')
| -rw-r--r-- | test/old/testdir/crash/poc_ex_substitute | bin | 0 -> 135 bytes | |||
| -rw-r--r-- | test/old/testdir/test_crash.vim | 13 |
2 files changed, 12 insertions, 1 deletions
diff --git a/test/old/testdir/crash/poc_ex_substitute b/test/old/testdir/crash/poc_ex_substitute Binary files differnew file mode 100644 index 0000000000..bcf1286512 --- /dev/null +++ b/test/old/testdir/crash/poc_ex_substitute diff --git a/test/old/testdir/test_crash.vim b/test/old/testdir/test_crash.vim index 1d4f435e4d..49e712a901 100644 --- a/test/old/testdir/test_crash.vim +++ b/test/old/testdir/test_crash.vim @@ -117,7 +117,7 @@ func Test_crash1_2() " The following used to crash Vim let opts = #{cmd: 'sh'} let vim = GetVimProg() - let result = 'X_crash1_1_result.txt' + let result = 'X_crash1_2_result.txt' let buf = RunVimInTerminal('sh', opts) @@ -149,6 +149,17 @@ func Test_crash1_2() \ ' ; echo "crash 4: [OK]" >> '.. result .. "\<cr>") call TermWait(buf, 150) + let file = 'crash/poc_ex_substitute' + let cmn_args = "%s -u NONE -i NONE -n -e -s -S %s -c ':qa!'" + let args = printf(cmn_args, vim, file) + " just make sure it runs, we don't care about the resulting echo + call term_sendkeys(buf, args .. "\<cr>") + " There is no output generated in Github CI for the asan clang build. + " so just skip generating the ouput. + " call term_sendkeys(buf, args .. + " \ ' && echo "crash 5: [OK]" >> '.. result .. "\<cr>") + call TermWait(buf, 150) + " clean up exe buf .. "bw!" |