1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
|
local t = require('test.testutil')
local n = require('test.functional.testnvim')()
local Screen = require('test.functional.ui.screen')
local api, clear, eq = n.api, n.clear, t.eq
local eval, exec, feed = n.eval, n.exec, n.feed
local exec_lua = n.exec_lua
describe('Signs', function()
local screen
before_each(function()
clear()
screen = Screen.new()
screen:add_extra_attr_ids {
[100] = { bold = true, foreground = Screen.colors.Magenta1 },
[101] = { foreground = Screen.colors.DarkBlue, background = Screen.colors.Yellow1 },
[102] = { foreground = Screen.colors.Brown, background = Screen.colors.Yellow },
[103] = { background = Screen.colors.Yellow, reverse = true },
[104] = { reverse = true, foreground = Screen.colors.Grey100, background = Screen.colors.Red },
}
end)
describe(':sign place', function()
it('allows signs with combining characters', function()
feed('ia<cr>b<cr><esc>')
exec([[
sign define piet1 text=𐌢̀́̂̃̅̄𐌢̀́̂̃̅̄ texthl=Search
sign define piet2 text=𠜎̀́̂̃̄̅ texthl=Search
sign place 1 line=1 name=piet1 buffer=1
sign place 2 line=2 name=piet2 buffer=1
]])
screen:expect([[
{101:𐌢̀́̂̃̅̄𐌢̀́̂̃̅̄}a |
{101:𠜎̀́̂̃̄̅}b |
{7: }^ |
{1:~ }|*10
|
]])
end)
it('shadows previously placed signs', function()
feed('ia<cr>b<cr>c<cr><esc>')
exec([[
sign define piet text=>> texthl=Search
sign define pietx text=>! texthl=Search
sign place 1 line=1 name=piet buffer=1
sign place 2 line=3 name=piet buffer=1
sign place 3 line=1 name=pietx buffer=1
]])
screen:expect([[
{101:>!}a |
{7: }b |
{101:>>}c |
{7: }^ |
{1:~ }|*9
|
]])
end)
it('allows signs with no text', function()
feed('ia<cr>b<cr><esc>')
exec('sign define piet1 text= texthl=Search')
exec('sign place 1 line=1 name=piet1 buffer=1')
screen:expect([[
a |
b |
^ |
{1:~ }|*10
|
]])
end)
it('can be called right after :split', function()
feed('ia<cr>b<cr>c<cr><esc>gg')
-- This used to cause a crash due to :sign using a special redraw
-- (not updating nvim's specific highlight data structures)
-- without proper redraw first, as split just flags for redraw later.
exec([[
set cursorline
sign define piet text=>> texthl=Search
split
sign place 3 line=2 name=piet buffer=1
]])
screen:expect([[
{7: }{21:^a }|
{101:>>}b |
{7: }c |
{7: } |
{1:~ }|*2
{3:[No Name] [+] }|
{7: }{21:a }|
{101:>>}b |
{7: }c |
{7: } |
{1:~ }|
{2:[No Name] [+] }|
|
]])
end)
it('can combine text, linehl and numhl', function()
feed('ia<cr>b<cr>c<cr><esc>')
exec([[
set number
sign define piet text=>> texthl=Search
sign define pietx linehl=ErrorMsg
sign define pietxx numhl=Folded
sign place 1 line=1 name=piet buffer=1
sign place 2 line=2 name=pietx buffer=1
sign place 3 line=3 name=pietxx buffer=1
sign place 4 line=4 name=piet buffer=1
sign place 5 line=4 name=pietx buffer=1
sign place 6 line=4 name=pietxx buffer=1
]])
screen:expect([[
{101:>>}{8: 1 }a |
{7: }{8: 2 }{9:b }|
{7: }{13: 3 }c |
{101:>>}{13: 4 }{9:^ }|
{1:~ }|*9
|
]])
-- Check that 'statuscolumn' correctly applies numhl
exec('set statuscolumn=%s%=%l\\ ')
screen:expect_unchanged()
end)
it('highlights the cursorline sign with culhl', function()
feed('ia<cr>b<cr>c<esc>')
exec([[
sign define piet text=>> texthl=Search culhl=ErrorMsg
sign place 1 line=1 name=piet buffer=1
sign place 2 line=2 name=piet buffer=1
sign place 3 line=3 name=piet buffer=1
set cursorline
]])
screen:expect([[
{101:>>}a |
{101:>>}b |
{9:>>}{21:^c }|
{1:~ }|*10
|
]])
feed('k')
screen:expect([[
{101:>>}a |
{9:>>}{21:^b }|
{101:>>}c |
{1:~ }|*10
|
]])
exec('set nocursorline')
screen:expect([[
{101:>>}a |
{101:>>}^b |
{101:>>}c |
{1:~ }|*10
|
]])
exec('set cursorline cursorlineopt=line')
screen:expect([[
{101:>>}a |
{101:>>}{21:^b }|
{101:>>}c |
{1:~ }|*10
|
]])
exec('set cursorlineopt=number')
exec('hi! link SignColumn IncSearch')
feed('Go<esc>2G')
screen:expect([[
{103:>>}a |
{104:>>}^b |
{103:>>}c |
{2: } |
{1:~ }|*9
|
]])
-- Check that 'statuscolumn' cursorline/signcolumn highlights are the same (#21726)
exec('set statuscolumn=%s')
screen:expect_unchanged()
end)
it('multiple signs #9295', function()
feed('ia<cr>b<cr>c<cr><esc>')
exec([[
set number
set signcolumn=yes:2
sign define pietSearch text=>> texthl=Search
sign define pietError text=XX texthl=Error
sign define pietWarn text=WW texthl=Warning
sign place 6 line=3 name=pietSearch buffer=1
sign place 7 line=3 name=pietWarn buffer=1
sign place 5 line=3 name=pietError buffer=1
]])
-- Line 3 checks that with a limit over the maximum number
-- of signs, the ones with the highest Ids are being picked,
-- and presented by their sorted Id order.
screen:expect([[
{7: }{8: 1 }a |
{7: }{8: 2 }b |
{7:WW}{101:>>}{8: 3 }c |
{7: }{8: 4 }^ |
{1:~ }|*9
|
]])
exec([[
sign place 1 line=1 name=pietSearch buffer=1
sign place 2 line=1 name=pietError buffer=1
" Line 2 helps checking that signs in the same line are ordered by Id.
sign place 4 line=2 name=pietSearch buffer=1
sign place 3 line=2 name=pietError buffer=1
]])
screen:expect([[
{9:XX}{101:>>}{8: 1 }a |
{101:>>}{9:XX}{8: 2 }b |
{7:WW}{101:>>}{8: 3 }c |
{7: }{8: 4 }^ |
{1:~ }|*9
|
]])
-- With the default setting, we get the sign with the top id.
exec('set signcolumn=yes:1')
screen:expect([[
{9:XX}{8: 1 }a |
{101:>>}{8: 2 }b |
{7:WW}{8: 3 }c |
{7: }{8: 4 }^ |
{1:~ }|*9
|
]])
-- "auto:3" accommodates all the signs we defined so far.
exec('set signcolumn=auto:3')
local s3 = [[
{9:XX}{101:>>}{7: }{8: 1 }a |
{101:>>}{9:XX}{7: }{8: 2 }b |
{7:WW}{101:>>}{9:XX}{8: 3 }c |
{7: }{8: 4 }^ |
{1:~ }|*9
|
]]
screen:expect(s3)
-- Check "yes:9".
exec('set signcolumn=yes:9')
screen:expect([[
{9:XX}{101:>>}{7: }{8: 1 }a |
{101:>>}{9:XX}{7: }{8: 2 }b |
{7:WW}{101:>>}{9:XX}{7: }{8: 3 }c |
{7: }{8: 4 }^ |
{1:~ }|*9
|
]])
-- Check "auto:N" larger than the maximum number of signs defined in
-- a single line (same result as "auto:3").
exec('set signcolumn=auto:4')
screen:expect(s3)
-- line deletion deletes signs.
exec('3move1')
exec('2d')
screen:expect([[
{9:XX}{101:>>}{8: 1 }a |
{101:>>}{9:XX}{8: 2 }^b |
{7: }{8: 3 } |
{1:~ }|*10
|
]])
-- character deletion does not delete signs.
feed('x')
screen:expect([[
{9:XX}{101:>>}{8: 1 }a |
{101:>>}{9:XX}{8: 2 }^ |
{7: }{8: 3 } |
{1:~ }|*10
|
]])
end)
it('auto-resize sign column with minimum size (#13783)', function()
feed('ia<cr>b<cr>c<cr><esc>')
exec('set number')
-- sign column should always accommodate at the minimum size
exec('set signcolumn=auto:1-3')
screen:expect([[
{7: }{8: 1 }a |
{7: }{8: 2 }b |
{7: }{8: 3 }c |
{7: }{8: 4 }^ |
{1:~ }|*9
|
]])
-- should support up to 8 signs at minimum
exec('set signcolumn=auto:8-9')
screen:expect([[
{7: }{8: 1 }a |
{7: }{8: 2 }b |
{7: }{8: 3 }c |
{7: }{8: 4 }^ |
{1:~ }|*9
|
]])
-- should keep the same sign size when signs are not exceeding
-- the minimum
exec('set signcolumn=auto:2-5')
exec('sign define pietSearch text=>> texthl=Search')
exec('sign place 1 line=1 name=pietSearch buffer=1')
screen:expect([[
{101:>>}{7: }{8: 1 }a |
{7: }{8: 2 }b |
{7: }{8: 3 }c |
{7: }{8: 4 }^ |
{1:~ }|*9
|
]])
-- should resize itself when signs are exceeding minimum but
-- not over the maximum
exec([[
sign place 2 line=1 name=pietSearch buffer=1
sign place 3 line=1 name=pietSearch buffer=1
sign place 4 line=1 name=pietSearch buffer=1
]])
screen:expect([[
{101:>>>>>>>>}{8: 1 }a |
{7: }{8: 2 }b |
{7: }{8: 3 }c |
{7: }{8: 4 }^ |
{1:~ }|*9
|
]])
-- should not increase size because sign with existing id is moved
exec('sign place 4 line=1 name=pietSearch buffer=1')
screen:expect_unchanged()
exec('sign unplace 4')
screen:expect([[
{101:>>>>>>}{8: 1 }a |
{7: }{8: 2 }b |
{7: }{8: 3 }c |
{7: }{8: 4 }^ |
{1:~ }|*9
|
]])
exec('sign place 4 line=1 name=pietSearch buffer=1')
-- should keep the column at maximum size when signs are
-- exceeding the maximum
exec([[
sign place 5 line=1 name=pietSearch buffer=1
sign place 6 line=1 name=pietSearch buffer=1
sign place 7 line=1 name=pietSearch buffer=1
sign place 8 line=1 name=pietSearch buffer=1
]])
screen:expect([[
{101:>>>>>>>>>>}{8: 1 }a |
{7: }{8: 2 }b |
{7: }{8: 3 }c |
{7: }{8: 4 }^ |
{1:~ }|*9
|
]])
end)
it('ignores signs with no icon and text when calculating the signcolumn width', function()
feed('ia<cr>b<cr>c<cr><esc>')
exec([[
set number
set signcolumn=auto:2
sign define pietSearch text=>> texthl=Search
sign define pietError text= texthl=Error
sign place 2 line=1 name=pietError buffer=1
]])
-- no signcolumn with only empty sign
screen:expect([[
{8: 1 }a |
{8: 2 }b |
{8: 3 }c |
{8: 4 }^ |
{1:~ }|*9
|
]])
-- single column with 1 sign with text and one sign without
exec('sign place 1 line=1 name=pietSearch buffer=1')
screen:expect([[
{101:>>}{8: 1 }a |
{7: }{8: 2 }b |
{7: }{8: 3 }c |
{7: }{8: 4 }^ |
{1:~ }|*9
|
]])
end)
it('signcolumn=number', function()
feed('ia<cr>b<cr>c<cr><esc>')
exec([[
set number signcolumn=number
sign define pietSearch text=>> texthl=Search numhl=Error
sign define pietError text= texthl=Search numhl=Error
sign place 1 line=1 name=pietSearch buffer=1
sign place 2 line=2 name=pietError buffer=1
]])
-- line number should be drawn if sign has no text
-- no signcolumn, line number for "a" is Search, for "b" is Error, for "c" is LineNr
screen:expect([[
{101: >> }a |
{9: 2 }b |
{8: 3 }c |
{8: 4 }^ |
{1:~ }|*9
|
]])
-- number column on wrapped part of a line should be empty
feed('gg100aa<Esc>')
screen:expect([[
{101: >> }aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa|
{9: }aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa|
{9: }aa^a |
{9: 2 }b |
{8: 3 }c |
{8: 4 } |
{1:~ }|*7
|
]])
api.nvim_buf_set_extmark(0, api.nvim_create_namespace('test'), 0, 0, {
virt_lines = { { { 'VIRT LINES' } } },
virt_lines_above = true,
})
feed('<C-Y>')
-- number column on virtual lines should be empty
screen:expect([[
{8: }VIRT LINES |
{101: >> }aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa|
{9: }aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa|
{9: }aa^a |
{9: 2 }b |
{8: 3 }c |
{8: 4 } |
{1:~ }|*6
|
]])
end)
it('can have 32bit sign IDs', function()
exec('sign define piet text=>> texthl=Search')
exec('sign place 100000 line=1 name=piet buffer=1')
feed(':sign place<cr>')
screen:expect([[
{101:>>} |
{1:~ }|*6
{3: }|
:sign place |
{100:--- Signs ---} |
{18:Signs for [NULL]:} |
line=1 id=100000 name=piet priority=10 |
|
{6:Press ENTER or type command to continue}^ |
]])
feed('<cr>')
screen:expect([[
{101:>>}^ |
{1:~ }|*12
|
]])
end)
end)
it('signcolumn width is updated when removing all signs after deleting lines', function()
api.nvim_buf_set_lines(0, 0, 1, true, { 'a', 'b', 'c', 'd', 'e' })
exec('sign define piet text=>>')
exec('sign place 10001 line=1 name=piet')
exec('sign place 10002 line=5 name=piet')
exec('2delete')
exec('sign unplace 10001')
screen:expect([[
{7: }a |
{7: }^c |
{7: }d |
{7:>>}e |
{1:~ }|*9
|
]])
exec('sign unplace 10002')
screen:expect([[
a |
^c |
d |
e |
{1:~ }|*9
|
]])
end)
it('signcolumn width is updated when removing all signs after inserting lines', function()
api.nvim_buf_set_lines(0, 0, 1, true, { 'a', 'b', 'c', 'd', 'e' })
exec('sign define piet text=>>')
exec('sign place 10001 line=1 name=piet')
exec('sign place 10002 line=5 name=piet')
exec('copy .')
exec('sign unplace 10001')
screen:expect([[
{7: }a |
{7: }^a |
{7: }b |
{7: }c |
{7: }d |
{7:>>}e |
{1:~ }|*7
|
]])
exec('sign unplace 10002')
screen:expect([[
a |
^a |
b |
c |
d |
e |
{1:~ }|*7
|
]])
end)
it('numhl highlight is applied when signcolumn=no', function()
screen:try_resize(screen._width, 4)
exec([[
set nu scl=no
call setline(1, ['line1', 'line2', 'line3'])
call nvim_buf_set_extmark(0, nvim_create_namespace('test'), 0, 0, {'number_hl_group':'Error'})
call sign_define('foo', { 'text':'F', 'numhl':'Error' })
call sign_place(0, '', 'foo', bufnr(''), { 'lnum':2 })
]])
screen:expect([[
{9: 1 }^line1 |
{9: 2 }line2 |
{8: 3 }line3 |
|
]])
end)
it('no negative b_signcols.count with undo after initializing', function()
exec([[
set signcolumn=auto:2
call setline(1, 'a')
call nvim_buf_set_extmark(0, nvim_create_namespace(''), 0, 0, {'sign_text':'S1'})
delete | redraw | undo
]])
end)
it('sign not shown on line it was previously on after undo', function()
exec([[
call setline(1, range(1, 4))
call nvim_buf_set_extmark(0, nvim_create_namespace(''), 1, 0, {'sign_text':'S1'})
]])
exec('norm 2Gdd')
exec('silent undo')
screen:expect([[
{7: }1 |
{7:S1}^2 |
{7: }3 |
{7: }4 |
{1:~ }|*9
|
]])
end)
it('sign_undefine() frees all signs', function()
exec([[
sign define 1 text=1
sign define 2 text=2
call sign_undefine()
]])
eq({}, eval('sign_getdefined()'))
end)
it('no crash when unplacing signs beyond end of buffer', function()
exec([[
sign define S1 text=S1
sign define S2 text=S2
sign place 1 line=8 name=S1
sign place 2 line=9 name=S2
]])
-- Now placed at end of buffer
local s1 = [[
{7:S2}^ |
{1:~ }|*12
|
]]
screen:expect(s1)
-- Signcolumn tracking used to not count signs placed beyond end of buffer here
exec('set signcolumn=auto:9')
screen:expect([[
{7:S2S1}^ |
{1:~ }|*12
|
]])
-- Unplacing the sign does not crash by decrementing tracked signs below zero
exec('sign unplace 1')
screen:expect(s1)
end)
it('signcolumn width is set immediately after splitting window #30547', function()
local infos = exec_lua([[
vim.o.number = true
vim.o.signcolumn = 'yes'
vim.cmd.wincmd('v')
return vim.fn.getwininfo()
]])
eq(6, infos[1].textoff)
eq(6, infos[2].textoff)
end)
it('auto width updated in all windows after sign placed in on_win #31438', function()
exec_lua([[
vim.cmd.call('setline(1, range(1, 500))')
vim.cmd('wincmd s | wincmd v | wincmd j | wincmd v')
_G.log, _G.needs_clear = {}, false
local ns_id, mark_id = vim.api.nvim_create_namespace('test'), nil
-- Add decoration which possibly clears all extmarks and adds one on line 499
local on_win = function(_, winid, bufnr, toprow, botrow)
if _G.needs_clear then
vim.api.nvim_buf_clear_namespace(bufnr, ns_id, 0, -1)
_G.needs_clear = false
end
if toprow < 499 and 499 <= botrow then
mark_id = vim.api.nvim_buf_set_extmark(bufnr, ns_id, 499, 0, { id = mark_id, sign_text = '!', invalidate = true })
end
end
vim.api.nvim_set_decoration_provider(ns_id, { on_win = on_win })
]])
screen:expect([[
1 │1 |
2 │2 |
3 │3 |
4 │4 |
5 │5 |
6 │6 |
{2:[No Name] [+] [No Name] [+] }|
^1 │1 |
2 │2 |
3 │3 |
4 │4 |
5 │5 |
{3:[No Name] [+] }{2:[No Name] [+] }|
|
]])
feed('G')
screen:expect([[
{7: }1 │{7: }1 |
{7: }2 │{7: }2 |
{7: }3 │{7: }3 |
{7: }4 │{7: }4 |
{7: }5 │{7: }5 |
{7: }6 │{7: }6 |
{2:[No Name] [+] [No Name] [+] }|
{7: }496 │{7: }1 |
{7: }497 │{7: }2 |
{7: }498 │{7: }3 |
{7: }499 │{7: }4 |
{7:! }^500 │{7: }5 |
{3:[No Name] [+] }{2:[No Name] [+] }|
|
]])
feed(':lua log, needs_clear = {}, true<CR>')
screen:expect([[
{7: }1 │{7: }1 |
{7: }2 │{7: }2 |
{7: }3 │{7: }3 |
{7: }4 │{7: }4 |
{7: }5 │{7: }5 |
{7: }6 │{7: }6 |
{2:[No Name] [+] [No Name] [+] }|
{7: }496 │{7: }1 |
{7: }497 │{7: }2 |
{7: }498 │{7: }3 |
{7: }499 │{7: }4 |
{7:! }^500 │{7: }5 |
{3:[No Name] [+] }{2:[No Name] [+] }|
:lua log, needs_clear = {}, true |
]])
end)
end)
|