asprintf returns -1, not an arbitrary value < 0. Also upon error the

(very sloppy specification) leaves an undefined value in *ret, so it is
wrong to inspect it, the error condition is enough.
discussed a little with nicm, and then much more with millert until we
were exasperated

1 files changed, 1 insertions, 1 deletions

diff --git a/xmalloc.c b/xmalloc.c
index 22ea3540..f249e397 100644
--- a/xmalloc.c
+++ b/xmalloc.c
@@ -111,7 +111,7 @@ xvasprintf(char **ret, const char *fmt, va_list ap)
 
 	i = vasprintf(ret, fmt, ap);
 
-	if (i < 0 || *ret == NULL)
+	if (i == -1)
 		fatalx("xasprintf: %s", strerror(errno));
 
 	return i;