diff options
| author | Nicholas Marriott <nicm@openbsd.org> | 2011-01-26 01:54:56 +0000 |
|---|---|---|
| committer | Nicholas Marriott <nicm@openbsd.org> | 2011-01-26 01:54:56 +0000 |
| commit | db7a89b1ee4c11006cdf607465b6c0fc13333fd1 (patch) | |
| tree | 5a6f12be811cd9f6ca649d23fcd4a482c5458b09 /cmd-run-shell.c | |
| parent | 4dfb29fa38a22615eda253b1124261379f6fbbcc (diff) | |
| download | rtmux-db7a89b1ee4c11006cdf607465b6c0fc13333fd1.tar.gz rtmux-db7a89b1ee4c11006cdf607465b6c0fc13333fd1.tar.bz2 rtmux-db7a89b1ee4c11006cdf607465b6c0fc13333fd1.zip | |
Simplify the way jobs work and drop the persist type, so all jobs are
fire-and-forget.
Status jobs now managed with two trees of output (new and old), rather
than storing the output in the jobs themselves. When the status line is
processed any jobs which don't appear in the new tree are started and
the output from the old tree displayed. When a job finishes it updates
the new tree with its output and that is used for any subsequent
redraws. When the status interval expires, the new tree is moved to the
old so that all jobs are run again.
This fixes the "#(echo %H:%M:%S)" problem which would lead to thousands
of identical persistent jobs and high memory use (this can still be
achieved by adding "sleep 30" but that is much less likely to happen by
accident).
Diffstat (limited to 'cmd-run-shell.c')
| -rw-r--r-- | cmd-run-shell.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/cmd-run-shell.c b/cmd-run-shell.c index 189eeac9..85cd1e29 100644 --- a/cmd-run-shell.c +++ b/cmd-run-shell.c @@ -53,7 +53,7 @@ cmd_run_shell_exec(struct cmd *self, struct cmd_ctx *ctx) { struct args *args = self->args; struct cmd_run_shell_data *cdata; - struct job *job; + const char *shellcmd = args->argv[0]; cdata = xmalloc(sizeof *cdata); cdata->cmd = xstrdup(args->argv[0]); @@ -64,9 +64,7 @@ cmd_run_shell_exec(struct cmd *self, struct cmd_ctx *ctx) if (ctx->curclient != NULL) ctx->curclient->references++; - job = job_add(NULL, 0, NULL, - args->argv[0], cmd_run_shell_callback, cmd_run_shell_free, cdata); - job_run(job); + job_run(shellcmd, cmd_run_shell_callback, cmd_run_shell_free, cdata); return (1); /* don't let client exit */ } |