1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
|
use std::ffi::OsStr;
use std::io::{self, Result};
use std::iter::once;
use std::os::windows::ffi::OsStrExt;
use std::sync::Arc;
use std::sync::mpsc::TryRecvError;
use crate::event::{OnResize, WindowSize};
use crate::tty::windows::child::ChildExitWatcher;
use crate::tty::{ChildEvent, EventedPty, EventedReadWrite, Options, Shell};
mod blocking;
mod child;
mod conpty;
use blocking::{UnblockedReader, UnblockedWriter};
use conpty::Conpty as Backend;
use miow::pipe::{AnonRead, AnonWrite};
use polling::{Event, Poller};
pub const PTY_CHILD_EVENT_TOKEN: usize = 1;
pub const PTY_READ_WRITE_TOKEN: usize = 2;
type ReadPipe = UnblockedReader<AnonRead>;
type WritePipe = UnblockedWriter<AnonWrite>;
pub struct Pty {
// XXX: Backend is required to be the first field, to ensure correct drop order. Dropping
// `conout` before `backend` will cause a deadlock (with Conpty).
backend: Backend,
conout: ReadPipe,
conin: WritePipe,
child_watcher: ChildExitWatcher,
}
pub fn new(config: &Options, window_size: WindowSize, _window_id: u64) -> Result<Pty> {
conpty::new(config, window_size)
}
impl Pty {
fn new(
backend: impl Into<Backend>,
conout: impl Into<ReadPipe>,
conin: impl Into<WritePipe>,
child_watcher: ChildExitWatcher,
) -> Self {
Self { backend: backend.into(), conout: conout.into(), conin: conin.into(), child_watcher }
}
pub fn child_watcher(&self) -> &ChildExitWatcher {
&self.child_watcher
}
}
fn with_key(mut event: Event, key: usize) -> Event {
event.key = key;
event
}
impl EventedReadWrite for Pty {
type Reader = ReadPipe;
type Writer = WritePipe;
#[inline]
unsafe fn register(
&mut self,
poll: &Arc<Poller>,
interest: polling::Event,
poll_opts: polling::PollMode,
) -> io::Result<()> {
self.conin.register(poll, with_key(interest, PTY_READ_WRITE_TOKEN), poll_opts);
self.conout.register(poll, with_key(interest, PTY_READ_WRITE_TOKEN), poll_opts);
self.child_watcher.register(poll, with_key(interest, PTY_CHILD_EVENT_TOKEN));
Ok(())
}
#[inline]
fn reregister(
&mut self,
poll: &Arc<Poller>,
interest: polling::Event,
poll_opts: polling::PollMode,
) -> io::Result<()> {
self.conin.register(poll, with_key(interest, PTY_READ_WRITE_TOKEN), poll_opts);
self.conout.register(poll, with_key(interest, PTY_READ_WRITE_TOKEN), poll_opts);
self.child_watcher.register(poll, with_key(interest, PTY_CHILD_EVENT_TOKEN));
Ok(())
}
#[inline]
fn deregister(&mut self, _poll: &Arc<Poller>) -> io::Result<()> {
self.conin.deregister();
self.conout.deregister();
self.child_watcher.deregister();
Ok(())
}
#[inline]
fn reader(&mut self) -> &mut Self::Reader {
&mut self.conout
}
#[inline]
fn writer(&mut self) -> &mut Self::Writer {
&mut self.conin
}
}
impl EventedPty for Pty {
fn next_child_event(&mut self) -> Option<ChildEvent> {
match self.child_watcher.event_rx().try_recv() {
Ok(ev) => Some(ev),
Err(TryRecvError::Empty) => None,
Err(TryRecvError::Disconnected) => Some(ChildEvent::Exited(None)),
}
}
}
impl OnResize for Pty {
fn on_resize(&mut self, window_size: WindowSize) {
self.backend.on_resize(window_size)
}
}
// Modified per stdlib implementation.
// https://github.com/rust-lang/rust/blob/6707bf0f59485cf054ac1095725df43220e4be20/library/std/src/sys/args/windows.rs#L174
fn push_escaped_arg(cmd: &mut String, arg: &str) {
let arg_bytes = arg.as_bytes();
let quote = arg_bytes.iter().any(|c| *c == b' ' || *c == b'\t') || arg_bytes.is_empty();
if quote {
cmd.push('"');
}
let mut backslashes: usize = 0;
for x in arg.chars() {
if x == '\\' {
backslashes += 1;
} else {
if x == '"' {
// Add n+1 backslashes to total 2n+1 before internal '"'.
cmd.extend((0..=backslashes).map(|_| '\\'));
}
backslashes = 0;
}
cmd.push(x);
}
if quote {
// Add n backslashes to total 2n before ending '"'.
cmd.extend((0..backslashes).map(|_| '\\'));
cmd.push('"');
}
}
fn cmdline(config: &Options) -> String {
let default_shell = Shell::new("powershell".to_owned(), Vec::new());
let shell = config.shell.as_ref().unwrap_or(&default_shell);
let mut cmd = String::new();
cmd.push_str(&shell.program);
for arg in &shell.args {
cmd.push(' ');
if config.escape_args {
push_escaped_arg(&mut cmd, arg);
} else {
cmd.push_str(arg)
}
}
cmd
}
/// Converts the string slice into a Windows-standard representation for "W"-
/// suffixed function variants, which accept UTF-16 encoded string values.
pub fn win32_string<S: AsRef<OsStr> + ?Sized>(value: &S) -> Vec<u16> {
OsStr::new(value).encode_wide().chain(once(0)).collect()
}
#[cfg(test)]
mod test {
use crate::tty::windows::{cmdline, push_escaped_arg};
use crate::tty::{Options, Shell};
#[test]
fn test_escape() {
let test_set = vec![
// Basic cases - no escaping needed
("abc", "abc"),
// Cases requiring quotes (space/tab)
("", "\"\""),
(" ", "\" \""),
("ab c", "\"ab c\""),
("ab\tc", "\"ab\tc\""),
// Cases with backslashes only (no spaces, no quotes) - no quotes added
("ab\\c", "ab\\c"),
// Cases with quotes only (no spaces) - quotes escaped but no outer quotes
("ab\"c", "ab\\\"c"),
("\"", "\\\""),
("a\"b\"c", "a\\\"b\\\"c"),
// Cases requiring both quotes and escaping (contains spaces)
("ab \"c", "\"ab \\\"c\""),
("a \"b\" c", "\"a \\\"b\\\" c\""),
// Complex real-world cases
("C:\\Program Files\\", "\"C:\\Program Files\\\\\""),
("C:\\Program Files\\a.txt", "\"C:\\Program Files\\a.txt\""),
(
r#"sh -c "cd /home/user; ARG='abc' \""'${SHELL:-sh}" -i -c '"'echo hello'""#,
r#""sh -c \"cd /home/user; ARG='abc' \\\"\"'${SHELL:-sh}\" -i -c '\"'echo hello'\"""#,
),
];
for (input, expected) in test_set {
let mut escaped_arg = String::new();
push_escaped_arg(&mut escaped_arg, input);
assert_eq!(escaped_arg, expected, "Failed for input: {}", input);
}
}
#[test]
fn test_cmdline() {
let mut options = Options {
shell: Some(Shell {
program: "echo".to_string(),
args: vec!["hello world".to_string()],
}),
working_directory: None,
drain_on_exit: true,
env: Default::default(),
escape_args: false,
};
assert_eq!(cmdline(&options), "echo hello world");
options.escape_args = true;
assert_eq!(cmdline(&options), "echo \"hello world\"");
}
}
|